fix(regex): resolve ReDoS timeout in typescript args extraction - #2156
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What\nThis PR fixes a Regular Expression Denial of Service (ReDoS) vulnerability in the
argsextraction rule for TypeScript, which was causing the CI pipeline to timeout after 180 seconds.\n\n### Why\nTheargsregex had an overlapping alternative in its nested parentheses matcher:\((?:[^()]|\([^()]*\)|\((?:[^()]|\([^()]*\))*\))*\). The middle alternative\([^()]*\)was fully subsumed by the third alternative, which matched up to depth 2. This created a classic ReDoS structure(A|B|C)*where B and C overlap, causing catastrophic backtracking on long inputs that ultimately fail to match.\n\n### How\nRemoved the redundant\([^()]*\)alternative from the three branches of the TypeScriptargsregex, converting it to\((?:[^()]|\((?:[^()]|\([^()]*\))*\))*\). This maintains the exact same depth-3 matching capabilities while eliminating the exponential backtracking. Verified by running the TypeScript test suite.