Skip to content

fix(regex): resolve ReDoS timeout in typescript args extraction #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
squid-protocol merged 2 commits into from
Aug 23, 2026
Merged

fix(regex): resolve ReDoS timeout in typescript args extraction #2156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e8f9fd
fix(regex): resolve ReDoS timeout in typescript args extraction
squid-protocol Aug 23, 2026
303d4dd
test: regenerate golden masters for typescript args fix
squid-protocol Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gitgalaxy/standards/language_standards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,10 +1048,10 @@ class PrismConfigSchema(TypedDict):
# same way Python's did (#1199). Name groups added to branches
# 1/4 too, purely so existing extraction tests keep passing.
"args": re.compile(
r"function\s+(\w*)(?:[ \t\n]{0,50}<(?:[^<>]|<[^<>]*>)*>)?[ \t\n]{0,50}(\((?:[^()]|\([^()]*\)|\((?:[^()]|\([^()]*\))*\))*\))|"
r"(\((?:[^()]|\([^()]*\)|\((?:[^()]|\([^()]*\))*\))*\))[^=;{]*=>|"
r"function\s+(\w*)(?:[ \t\n]{0,50}<(?:[^<>]|<[^<>]*>)*>)?[ \t\n]{0,50}(\((?:[^()]|\((?:[^()]|\([^()]*\))*\))*\))|"
r"(\((?:[^()]|\((?:[^()]|\([^()]*\))*\))*\))[^=;{]*=>|"
r"([a-zA-Z_$][\w$]{0,100})[ \t]*=>|"
r"^[ \t]*(?:(?:public|private|protected|static|override|abstract|readonly)[ \t]+){0,4}(?:async[ \t]+)?(?:\*[ \t]*)?(?:get\s+|set[ \t]+)?(?!(?:if|for|while|switch|catch|return|throw|new|typeof|yield|await|void)\b)(\[[^\]]+\]|[#]?[a-zA-Z_$][\w$]*)(?:[ \t\n]{0,50}<(?:[^<>]|<[^<>]*>)*>)?[ \t\n]{0,50}(\((?:[^()]|\([^()]*\)|\((?:[^()]|\([^()]*\))*\))*\))",
r"^[ \t]*(?:(?:public|private|protected|static|override|abstract|readonly)[ \t]+){0,4}(?:async[ \t]+)?(?:\*[ \t]*)?(?:get\s+|set[ \t]+)?(?!(?:if|for|while|switch|catch|return|throw|new|typeof|yield|await|void)\b)(\[[^\]]+\]|[#]?[a-zA-Z_$][\w$]*)(?:[ \t\n]{0,50}<(?:[^<>]|<[^<>]*>)*>)?[ \t\n]{0,50}(\((?:[^()]|\((?:[^()]|\([^()]*\))*\))*\))",
re.M,
),
# 3. linear (Sequential Boundaries)
Expand Down
14 changes: 7 additions & 7 deletions tests/golden_master_audit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
"pyyaml": false
},
"Target Root Name": "data",
"Absolute Project Path": "/home/joe/nyx_projects/gitgalaxy/language-crucible/data",
"Analysis ISO Timestamp": "2026-08-22T23:29:18.739169+00:00",
"Total Scan Duration": "99.29 seconds"
"Absolute Project Path": "/home/joe/nyx_projects/language-crucible/data",
"Analysis ISO Timestamp": "2026-08-23T14:26:05.679560+00:00",
"Total Scan Duration": "37.6 seconds"
},
"Source Control Footprint (Immutable Anchor)": {
"Active Branch": "HEAD",
"Commit Hash (SHA-1)": "12fc7affb76fbecfeaf93f38b7b5e7597d8f294b",
"Remote Origin URL": "https://github.com/squid-protocol/language-crucible.git",
"Remote Origin URL": "https://github.com/squid-protocol/language-crucible",
"Last Code Integration Date": "2026-07-03T07:10:50-04:00"
}
},
Expand Down Expand Up @@ -343594,7 +343594,7 @@
"7. Structural Signatures (Net Mitigated Signals)": {
"Control Flow Branches": 1144,
"Sequential Logic Declarations": 416,
"Function Parameters": 0,
"Function Parameters": 73,
"Function/Method Declarations": 63,
"Class/Entity Declarations": 3,
"Defensive Programming Constructs": 8,
Expand Down Expand Up @@ -363684,7 +363684,7 @@
"7. Structural Signatures (Net Mitigated Signals)": {
"Control Flow Branches": 378,
"Sequential Logic Declarations": 339,
"Function Parameters": 0,
"Function Parameters": 262,
"Function/Method Declarations": 217,
"Class/Entity Declarations": 9,
"Defensive Programming Constructs": 171,
Expand Down Expand Up @@ -369649,7 +369649,7 @@
"7. Structural Signatures (Net Mitigated Signals)": {
"Control Flow Branches": 203,
"Sequential Logic Declarations": 306,
"Function Parameters": 0,
"Function Parameters": 154,
"Function/Method Declarations": 99,
"Class/Entity Declarations": 32,
"Defensive Programming Constructs": 77,
Expand Down
14 changes: 7 additions & 7 deletions tests/golden_master_zero_dep_audit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
"pyyaml": false
},
"Target Root Name": "data",
"Absolute Project Path": "/home/joe/nyx_projects/gitgalaxy/language-crucible/data",
"Analysis ISO Timestamp": "2026-08-22T23:31:11.100235+00:00",
"Total Scan Duration": "96.06 seconds"
"Absolute Project Path": "/home/joe/nyx_projects/language-crucible/data",
"Analysis ISO Timestamp": "2026-08-23T14:51:21.505051+00:00",
"Total Scan Duration": "37.45 seconds"
},
"Source Control Footprint (Immutable Anchor)": {
"Active Branch": "HEAD",
"Commit Hash (SHA-1)": "12fc7affb76fbecfeaf93f38b7b5e7597d8f294b",
"Remote Origin URL": "https://github.com/squid-protocol/language-crucible.git",
"Remote Origin URL": "https://github.com/squid-protocol/language-crucible",
"Last Code Integration Date": "2026-07-03T07:10:50-04:00"
}
},
Expand Down Expand Up @@ -343594,7 +343594,7 @@
"7. Structural Signatures (Net Mitigated Signals)": {
"Control Flow Branches": 1144,
"Sequential Logic Declarations": 416,
"Function Parameters": 0,
"Function Parameters": 73,
"Function/Method Declarations": 63,
"Class/Entity Declarations": 3,
"Defensive Programming Constructs": 8,
Expand Down Expand Up @@ -363684,7 +363684,7 @@
"7. Structural Signatures (Net Mitigated Signals)": {
"Control Flow Branches": 378,
"Sequential Logic Declarations": 339,
"Function Parameters": 0,
"Function Parameters": 262,
"Function/Method Declarations": 217,
"Class/Entity Declarations": 9,
"Defensive Programming Constructs": 171,
Expand Down Expand Up @@ -369649,7 +369649,7 @@
"7. Structural Signatures (Net Mitigated Signals)": {
"Control Flow Branches": 203,
"Sequential Logic Declarations": 306,
"Function Parameters": 0,
"Function Parameters": 154,
"Function/Method Declarations": 99,
"Class/Entity Declarations": 32,
"Defensive Programming Constructs": 77,
Expand Down
Loading