fix(security): SHA-pin the setup-cli action in generated workflows#384
Merged
Conversation
joshua-temple
changed the title
The generated orchestrate and promote workflows referenced stablekernel/cascade/.github/actions/setup-cli by version tag, which the PinnedDependencies code scanner flags (5 medium alerts). Add an optional cli_version_sha field paired with cli_version: when pin_mode is sha and the SHA is set, the generator emits setup-cli@<sha> # <version>, otherwise the tag (unchanged for non-opted-in adopters). Generation stays a pure offline function of the committed manifest; the SHA is resolved by the CLI-version-bump automation, which peels the annotated release tag to its commit (the fleet repin now peels the rc tag and writes cli_version_sha before regenerating). Set cascade's own cli_version_sha and regenerate, clearing alerts #48-#52. Consolidates the duplicated getCLIRef emission into one cliSetupRef helper. Part of #373; closes #383. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
joshua-temple
force-pushed
the
security/sha-pin-setup-cli
branch
from
cec0078 to
51b0300
Compare
joshua-temple
added a commit
that referenced
this pull request
Jun 27, 2026
…WriteManifestState (#389) orchestrate writeConfig and external writeManifest re-marshaled the typed CICDFile, dropping any manifest config the running binary does not model (and writeConfig dropped the ci: wrapper). This is the last lossy state-write class after #350/#371: it strips cli_version_sha (added in #384) on the next state commit for a binary that predates it, leaving a pin_mode:sha repo with SHA-pinned workflows but a manifest that no longer declares the pin, which reads as permanent drift and would re-open the setup-cli code-scanning alerts. Route both writers through config.WriteManifestState so only state and latest_release change and all other config, modeled or not, survives verbatim. Closes #372. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Generated orchestrate.yaml and promote.yaml referenced
stablekernel/cascade/.github/actions/setup-cli@v0.1.0by version tag, flagged by the PinnedDependencies scanner (5 medium alerts #48-#52). actions/checkout is already SHA-pinned; only the cross-repo setup-cli self-reference was unpinned.Fix
Add an optional
cli_version_shafield paired withcli_version. Whenpin_mode: shaand the SHA is set, the generator emitssetup-cli@<sha> # <version>; otherwise the tag (unchanged for non-opted-in adopters). Generation stays a pure offline function of the committed manifest (no network in the generator, so hermetic tests, the offline e2e harness, and drift determinism are preserved); the SHA is resolved by the CLI-version-bump automation. cascade's release tags are annotated, so the automation peels to the commit (refs/tags/<tag>^{}) - the fleet repin now peels the rc and writescli_version_shabefore regenerating, SHA-pinning the example repos too. Consolidates ~10 duplicatedgetCLIRefbodies into onecliSetupRef.Sets cascade's own
cli_version_shaand regenerates: all 5 refs are nowsetup-cli@9dc69a1f... # v0.1.0, clearing the alerts. e2e scenarios 41 (sha-pin) + 42 (fallback to tag). go test ./... 2013 pass; lint/actionlint/drift clean. Closes #383.