Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foreground commands can stall a non-interactive session when a child process keeps an output pipe open, and shortened error output can hide the information needed to recover. This adds a 120-second default for Step
run_command, cleans up discoverable Linux descendants on timeout or abort, reports signal termination as failure, and preserves a readable full log when command output is shortened.The change also keeps runtime state from interfering with solution delivery:
STEP_CODING_AGENT_PLAN_DIRoptionally stores plans outside the workspace. Existing defaults and saved session paths remain authoritative.--completion-check git-committedchecks delivery in the same session. Optional--completion-reviewshares the existing follow-up budget.Explicit command timeouts, background execution, and permission decisions keep their contracts. Linux descendant snapshots cannot atomically contain already-reparented descendants or forks racing the snapshot. This change adds no dependency.
Validation:
npm run checkand the complete offline./test.shsuite pass. Coverage includes real local subprocess timeout/signal recovery, complete saved-output reads, plan resume behavior, compaction checkpoint integrity, summary budgets, and the HTTP serializer. CLI dispatch fixtures invoke the workspace build refreshed by CI, preserving their assertions and subprocess deadlines. The full suite was run with a three-CPU affinity limit to avoid oversubscribing this shared host; test timeouts were unchanged. An unchanged 12 MiB feedback-redaction stress test also passed in isolation after timing out during the initial high-concurrency run.Full benchmark comparison is still in progress; this PR does not claim a final score improvement. Denial-recovery configuration is tracked separately in #188.