chore: sync new capability IDs from canonical spec - #1786
Merged
Conversation
spydon
approved these changes
Aug 31, 2026
spydon
added a commit
that referenced
this pull request
Aug 31, 2026
…trix (#1787) ## What The capability-ID sync in #1786 added `auth.sign_in.concurrent_pkce_flows` to `sdk-compliance.yaml` with the default `not_implemented` status. The capability is already implemented, so this marks it `implemented` and gives it the symbols that describe it. ## Why it is already implemented The canonical capability asks for each PKCE code verifier to live in its own bounded, per-flow slot keyed by a generated flow id, with the code exchange accepting an optional flow id to select the right verifier. That is what `PKCEVerifierStore` does, landed in #1662 and refactored in #1744: - Each flow gets its own storage slot, pending ids are tracked in an index entry, and starting another flow past `AuthConstants.pkceMaxConcurrentFlows` (5) evicts the oldest. - `AuthClient.exchangeCodeForSession` takes an optional `flowId` and validates it before building a storage key. - `AuthClient.appendPkceFlowIdToRedirects` and `AuthClientOptions.appendPkceFlowIdToRedirects` put the id on the callback URL, and `getOAuthSignInUrl` / `getLinkIdentityUrl` return it as `OAuthResponse.flowId`. ## Changes `AuthClient.appendPkceFlowIdToRedirects`, `AuthClientOptions.appendPkceFlowIdToRedirects` and `OAuthResponse.flowId` move from `auth.sign_in.exchange_code_for_session` to the new capability, which is where they belong now that it exists. `exchange_code_for_session` keeps `AuthClient.exchangeCodeForSession`. No note is added, since the implementation matches expected parity. ## Verification The supabase/sdk compliance tooling was run locally against this branch: ``` validate-compliance OK — compliance file is valid. check-api-symbols All new public API symbols are covered in the capability matrix. check-drift No capability matrix drift detected. ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added support for handling multiple concurrent PKCE authentication flows. * **Bug Fixes** * Updated sign-in capability reporting to accurately associate PKCE flow support with concurrent authentication flows. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New capability IDs from https://github.com/supabase/sdk were added as
not_implemented.Triage each one: set the real status and add symbols/notes before merging.-
auth.sign_in.concurrent_pkce_flows