Repository navigation
✨ Load external components with xmd repl --include - #972
Merged
Merged
Conversation
PR #972: ✨ Load external components with xmd repl --include8 files, +687 / -39 Scope🟡 726 lines changed. PRs under 400 receive more thorough review. StructuralOxlint structural signals:
SlopOxlint slop signals:
Static AnalysisOxlint: 16 diagnostics across 2 files (9 rules) no-unused-vars (3): packages/cli/src/cli.ts CorrectnessNo extraneous code patterns detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Authors can load their own components into an interactive session with
deno task xmd repl --include ./components, addressing #968.What changes
Before: the REPL has no
--includeoption, so a component directory used by ordinary document runs cannot be selected for the interactive session.After: repeated
--includearguments select component directories in the authored order. The selected vocabulary is shared by execution, preflight and Sidekick documentation. Relative paths resolve from the invocation directory; omitted options preserve the existing bundled components.How to verify it
Focused grammar/help, profile/execution and source terminal regressions pass. The terminal journey covers ordering, reverse order, omitted options, protected names and reopening completed history without repeating effects. Both original reviewers passed signed commit
a4907b468777e4112f87ff80d26f0e692fa73e35.Required CI and runner-produced test weights are pending. This remains a draft until delivery verification and final metadata review finish.
Scope
CLI argument handling, the existing REPL profile, focused regression coverage and the REPL specification.
Scope confirmation