fix(AppShell): wire up <keyname> control hint - #2153
Open
alexwarren wants to merge 1 commit into
Open
Conversation
<keyname> was fully dead (4 uses, all on CoreEditorObjectUseGive.aslx's
useon/selfuseon multi controls) - a "multi" control's nested scriptdictionary
sub-editor always showed generic "Add entry key…"/"Select object…" wording,
even though useon/selfuseon's keys are specifically object names ("Object").
Threads ctrl.GetString("keyname") through the "multi" branch of
ToControlInfo into a new keyLabel prop on ScriptDictionaryEditor.svelte,
which swaps in the more specific wording (e.g. "Add Object…"/"Select
Object…") when set, falling back to the existing generic text otherwise.
Part of #2116.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<keyname>was fully dead (4 uses, all inCoreEditorObjectUseGive.aslxon theuseon/selfuseonmulticontrols). Amulticontrol's nested scriptdictionary sub-editor (e.g. "Use (other object) on this" → "Handle objects individually") always showed generic "Add entry key…" / "Select object…" wording, even though these particular keys are specifically object names and the.aslxalready declares<keyname>Object</keyname>to say so.ctrl.GetString("keyname")through the"multi"branch ofToControlInfointo a newkeyLabelprop onScriptDictionaryEditor.svelte, which swaps in the more specific wording ("Add Object…" / "Select Object…") when set, and falls back to the existing generic text otherwise (both call sites ofScriptDictionaryEditorunder a"multi"sub-editor pass it; the unrelated top-levelscriptdictionarycontroltype call site, e.g.AttributesEditor, is untouched since<keyname>never applies there).Noticed in passing but out of scope: the same
useon/selfuseoncontrols also declare<keyprompt>, which is also dead for"multi"controls specifically (it's already wired forstringdictionary/gamebookoptions, just notmulti) - not part of this issue's tracked tag list, so left alone here rather than expanding scope.Test plan
dotnet build --configuration Releasedotnet test --configuration Release(all passing)npm run check/npm run lintinsrc/AppShell(clean)node tests/e2e/find-affected-tests.mjs+ ran the relevant flagged scripts (verify-appshell-verbs-editor, verify-appshell-attributes-panel-pinned) against a local dev server - all pass.🤖 Generated with Claude Code