fix(AppShell): wire up <keyprompt> for multi controltype - #2157
Closed
alexwarren wants to merge 1 commit into
Closed
fix(AppShell): wire up <keyprompt> for multi controltype#2157alexwarren wants to merge 1 commit into
alexwarren wants to merge 1 commit into
Conversation
<keyprompt> was silently dropped whenever it was declared on a "multi"
controltype control (useon/selfuseon/give/giveto in
CoreEditorObjectUseGive.aslx) - ToControlInfo's "multi" branch never read
it, even though ControlInfo.KeyPrompt and the reading pattern for it
already exist for stringdictionary/gamebookoptions controls.
Threads ctrl.GetString("keyprompt") through the "multi" branch alongside
the just-added KeyName, and wires it into ScriptDictionaryEditor.svelte's
existing keyLabel prop as a tooltip (title attribute) on the add-row
input, since keyPrompt's longer descriptive sentence doesn't fit as
placeholder/aria-label text the way keyLabel's short noun does.
Follow-up to #2153, part of #2116.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
alexwarren
added a commit
that referenced
this pull request
Aug 27, 2026
Same dead-tag pattern as <keyname> above, spotted while reviewing #2157 (stacked PR proposing to wire this up as a tooltip on the object-picker <select>). ToControlInfo's "multi" branch never reads <keyprompt> - it's only wired for the "isDictionary" (stringdictionary/gamebookoptions) branch - and the specific text here ("Please enter the object name") is actively wrong for these controls anyway: they all set <source>object</source>, so the add-row control is a <select> of real object names, not a free-text field to type into. Not worth wiring up; removed the tag from all 4 usages instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
6 tasks
Contributor
Author
|
Closing this rather than rebasing it. Same call as #2153's revert of
I've removed the dead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<keyprompt>was silently dropped whenever declared on a "multi" controltype control (useon/selfuseon/give/giveto inCoreEditorObjectUseGive.aslx) —ToControlInfo's"multi"branch never read it, even thoughControlInfo.KeyPromptand the reading pattern for it already exist for stringdictionary/gamebookoptions controls.ctrl.GetString("keyprompt")through the"multi"branch alongside the just-addedKeyName(fix(AppShell): remove dead <keyname> control hint #2153), and wires it intoScriptDictionaryEditor.svelte's existingkeyLabelprop as a tooltip (titleattribute) on the add-row input —keyPrompt's longer descriptive sentence (e.g. "Please enter the object name") doesn't fit as placeholder/aria-label text the waykeyLabel's short noun ("Object") does.Stacked on #2153 (base branch set to
fix/editor-keyname-hint) since it depends on theKeyName/keyLabelplumbing added there. Part of #2116.Test plan
dotnet build --configuration Release/dotnet test --configuration Release— all passnpm run check/npm run lintinsrc/AppShell— cleannode tests/e2e/find-affected-tests.mjs— ran all 41 flagged scripts; 36 pass, 5 confirmed pre-existing failures unrelated to this change (verified viagit stashA/B comparison on the same server)title="Please enter the object name"(resolved[EditorObjectUseGivePleaseenter]text) alongside the existing "Select Object…"/"Add Object" wording from<keyname>🤖 Generated with Claude Code