Repository navigation
Chore: Wasm npm lock at gradle/wasm-yarn.lock, no root kotlin-js-store - #114
Merged
Merged
Conversation
…oot kotlin-js-store (#110)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #110
Maintainer decision: the build's single Kotlin/Wasm npm lock (one workspace for every wasm module; KGP 2.4 allows only a root setting) lives next to the version catalog. Root build sets WasmYarnRootExtension.lockFileDirectoryProperty=gradle, lockFileNameProperty=wasm-yarn.lock (non-deprecated API); mismatch report stays FAIL. Lock moved with git mv (content unchanged: @js-joda/core).
Verification (coordinator): kotlinWasmNpmInstall + kotlinWasmStoreYarnLock OK (Restore/Store tasks ran against gradle/wasm-yarn.lock, timestamp updated, content unchanged, nothing written under kotlin-js-store/); :python-multiplatform:compileKotlinWasmJs + :sample:compileKotlinWasmJs OK.