Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retries: Infinityis meant to retry forever:retry.operation()already treats it likeforever: true. Butretry.timeouts()first tries to build an endless array of timeouts, so the process hangs until V8 aborts with "invalid size error". p-retry users hit this too.retry.timeouts()now builds a finite backoff forretries: Infinityinstead:maxTimeout, the timeouts grow until they reachmaxTimeout, capped at 1000 timeouts.{ factor: 1.1, maxTimeout: 60000 }ramps up to 60000 instead of stalling partway.factor <= 1the timeouts never grow, so a single timeout is enough.retry.operation()andretry.wrap()then keep repeating the last timeout, likeforever: truedoes. Callingretry.timeouts({ retries: Infinity })directly returns that finite list instead of hanging. It can't carry the "forever" flag, so the README documents the forever behavior underretry.operation().Unlike #77, this doesn't mutate the caller's
options, and it keepsretries: 0and other falsy values.Fixes #84
Supersedes #77
🤖 Generated with Claude Code