Repository navigation
Preserve native media and expose transport input support - #61
Conversation
…es media Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper review
|
|
Warning Review limit reached
This review includes 28 billable files and costs up to $7.00. Or wait 5 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (28)
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Requesting changes: 1 lane(s) blocking, worst finding is high.
Fix or reply to the findings below and push. The next review clears this automatically once they are gone — you should not need to dismiss anything by hand.
$0.0011 · 51,124 in / 4,615 out · 25,856 cached (51%) · deepseek/deepseek-v4-flash
description: $0.0007 · 25,075 in / 341 out · 0 cached (0%) · deepseek/deepseek-v4-flash
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c76ed9eac0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ures Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
Fixed the socket-fixture finding in f57b99a. The newly added successful-media tests now inspect synthetic provider request payloads and rely on synthetic byte-stream reconstruction coverage; the TCP listener fixture was removed. Public invoke/stream malformed-media rejection tests still assert a validation error before transport can run. Assistant text, thinking omission, tool IDs and serialized arguments remain covered by a pure serializer regression. Fresh verification: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f57b99adba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
Independent code review (Luna Agents), PR #61, exact head 84d4caf: APPROVED. No critical or important findings. The review verified the capability remains default-closed, unknown/denied formats are intersected safely, unsupported/local-path media is rejected before I/O, Responses PDF support remains opt-in and defaults off, and wrapper forwarding is correct. CI checks for stable Rust, Rust 1.88 MSRV, and supply chain are green. TinySweeper timed out with an explicit report that no code was reviewed; its check instructions permit hand merge after independent review. |
Native attachment routing needs separate facts for the selected model and its transport. This adds conservative
ChatModel::supports_inputchecks, preserves discovered input modalities, and serializes images in OpenAI Responses with PDF input enabled only when explicitly confirmed. Unsupported media and malformed inline Base64 fail before transport instead of being silently dropped.Validation (all pass, run from this repository root):
cargo test --workspace --all-features cargo clippy --workspace --all-targets --all-features -- -D warnings cargo fmt --all -- --checkThe LLM suite has 568 unit tests, one integration test, and one doctest. New regressions cover tied and unequal context windows, unknown and empty modality facts, root-level capability exports, modality-only discovery supplementation, pure native-media serialization, and public invoke/stream rejection before I/O. New successful-media tests use synthetic payloads; no socket fixture is added.
Dependency for tinyhumansai/openhuman#6964.