Skip to content

Add exact Qwen3.5 LoRA projection topology - #47

Closed
kiddyboots216 wants to merge 2 commits into
docs/public-docs-refresh-20260810from
feature/qwen35-lora-projection-topology-20260811
Closed

Add exact Qwen3.5 LoRA projection topology#47
kiddyboots216 wants to merge 2 commits into
docs/public-docs-refresh-20260810from
feature/qwen35-lora-projection-topology-20260811

Conversation

@kiddyboots216

@kiddyboots216 kiddyboots216 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep Qwen3.5/3.6 GDN q, k, v, and z projections as independent rank-16 adapters.
  • Add independent shared-expert gate, up, and down factors while preserving the fused gate/up base GEMM.
  • Use the same folded weights in regular forward, ordered EP combine, and synchronized serving weights.
  • Align the shipped Qwen3.5 LoRA example with exact admission: FlashAttention 4, Triton MoE, and all-to-all EP.
  • Validate the parsed shipped configuration through the exact numerical-program and MoE admission resolvers.
  • Add topology, checkpoint, one-GPU lifecycle, and two-rank FSDP2 coverage.

Stack

Validation

  • Final focused model, argument, runner, and weight-sync suite: 103 passed, 31 expected skips.
  • Changed Python files: Ruff passed.
  • The one-GPU update/sync/checkpoint/reload and two-rank NCCL/FSDP2 replay payloads remain patch-equivalent across the restack.

@broly-code-security-scanner

broly-code-security-scanner Bot commented Aug 11, 2026

Copy link
Copy Markdown

Broly Security Scan

Note

Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.2) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

@kiddyboots216
kiddyboots216 force-pushed the feature/qwen35-lora-projection-topology-20260811 branch from 37dbab4 to f5790bc Compare August 11, 2026 22:47
@kiddyboots216
kiddyboots216 changed the base branch from cleanup-tests to docs/public-docs-refresh-20260810 August 11, 2026 22:47
@kiddyboots216
kiddyboots216 force-pushed the docs/public-docs-refresh-20260810 branch from b6bac60 to 45a087a Compare August 12, 2026 02:29
@kiddyboots216
kiddyboots216 force-pushed the feature/qwen35-lora-projection-topology-20260811 branch from f5790bc to 89e4d2e Compare August 12, 2026 02:29
@kiddyboots216
kiddyboots216 force-pushed the docs/public-docs-refresh-20260810 branch from 45a087a to f22c5cf Compare August 12, 2026 03:17
@kiddyboots216
kiddyboots216 force-pushed the feature/qwen35-lora-projection-topology-20260811 branch from 89e4d2e to 26d0a98 Compare August 12, 2026 03:17
@kiddyboots216
kiddyboots216 force-pushed the docs/public-docs-refresh-20260810 branch from f22c5cf to 26d079f Compare August 12, 2026 03:20
@kiddyboots216
kiddyboots216 force-pushed the feature/qwen35-lora-projection-topology-20260811 branch from 26d0a98 to 95d9545 Compare August 12, 2026 03:20
@kiddyboots216
kiddyboots216 force-pushed the docs/public-docs-refresh-20260810 branch from 26d079f to f3023a0 Compare August 12, 2026 04:03
@kiddyboots216
kiddyboots216 force-pushed the feature/qwen35-lora-projection-topology-20260811 branch from 95d9545 to 0458504 Compare August 12, 2026 04:03
@kiddyboots216
kiddyboots216 force-pushed the docs/public-docs-refresh-20260810 branch from f3023a0 to 8881321 Compare August 12, 2026 04:07
@kiddyboots216
kiddyboots216 force-pushed the feature/qwen35-lora-projection-topology-20260811 branch from 0458504 to d1711e0 Compare August 12, 2026 04:08
@kiddyboots216
kiddyboots216 requested a review from qywu August 12, 2026 04:11
@kiddyboots216

Copy link
Copy Markdown
Contributor Author

Superseded by #57, which consolidates the complete exact trainer-serving stack directly onto main.

@kiddyboots216
kiddyboots216 deleted the feature/qwen35-lora-projection-topology-20260811 branch August 17, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant