Consolidate exact trainer-serving parity

[kiddyboots216]

Summary

This consolidates the exact trainer-side work previously split across the earlier XoRL PRs into one branch based directly on main. It is paired with togethercomputer/xorl-sglang#21.

Highlights

• Adds exact trainer-serving programs for dense and MoE Qwen3.x, GLM-5.2, and DeepSeek-V4, including one-round SwiGLU, exact GDN/attention/head paths, canonical routing replay, and decision-time logprob replay.
• Supports physical pipeline-parallel training for the exact model paths, carrying model-owned boundary state and ragged metadata while dispatching terminal CE, policy, IS, DRGRPO, CISPO, and ordinary OPD objectives.
• Composes logical row ownership across mixed DP × CP layouts for GLM and DeepSeek, including ragged rows, DP-aware LoRA/expert routing, and DeepSeek PP × CP storage/wire handling.
• Replays per-row temperature, top-k, top-p, and min-p from normalized serving metadata.
• Uses one canonical local MoE arithmetic contract across Qwen, GLM, and DeepSeek: BF16/FP16 transport, deterministic source ordering, FP32 leaf and adjacent/odd-tail tree accumulation, then one final output cast.
• Retains GLM-5.2 full-parameter block-FP8 training, including scoped trainable components, frozen-trunk backward, optimizer/cache refresh, and full-weight publication.
• Includes routed-expert replay throughput/side-channel integration and CISPO loss support.

Validation

• Focused suites cover real PP2 × CP2 DeepSeek forward/backward, physical-PP objectives, mixed and ragged ownership, exact sampling replay, canonical MoE arithmetic, and GLM full-parameter wiring.
• Cross-engine GPU checks compare the independent trainer and serving leaf/fold implementations for BF16 and FP16 contributor payloads.
• Changed-range hygiene and focused validation pass locally; GitHub checks are tracked on this PR.

Companion serving change

• Consolidate exact serving contracts for XoRL xorl-sglang#21

Out of scope

Sparse-delta receiver integration is intentionally not included.

[broly-code-security-scanner]

Broly Security Scan

Note

Summary

4 actionable finding(s) in this PR
5 total in scan · 0 dismissed false positives

• 🟡 4 medium

All actionable items are in the table below.

1 finding(s) below the medium reporting threshold are not listed above — see the repository Security tab for the full set.

No finding is at or above high, so this check is not blocking. The findings above are still tracked and reported.

Severity	Scanner	Issue	Location	Dismiss	Verdict
🟡 MEDIUM	SAST	Arbitrary file deletion via R3SourceFilesCleanup using attacker-controlled paths	src/xorl/server/orchestrator/request_processor.py:555	d53	🔺 TRUE_POSITIVE · Confidence: HIGH
🟡 MEDIUM	SAST	Path traversal via R3 source path validation bypass using symlinks	src/xorl/server/orchestrator/request_processor.py:407	d52	🔺 TRUE_POSITIVE · Confidence: HIGH
🟡 MEDIUM	SAST	Unsafe deserialization of PyTorch files via torch.load from an environment-controlled path.	src/xorl/server/runner/model_runner.py:2893	d54	🔺 TRUE_POSITIVE · Confidence: HIGH
🟡 MEDIUM	SAST	Unsafe deserialization via torch.from_file of attacker-controlled file paths in SGLang R3 routi...	src/xorl/server/runner/runner_dispatcher.py:1499	d55	🔺 TRUE_POSITIVE · Confidence: HIGH

Dismiss false positives

Tick a box to dismiss the finding; untick it to bring the finding back. That is the same as replying /broly dismiss d1 and /broly undismiss d1. To record why it is a false positive, reply with /broly dismiss d1: your reason instead — Broly reuses those reasons to triage similar findings across the org.

• d52 · 🟡 MEDIUM   · src/xorl/server/orchestrator/request_processor.py:407 · Path traversal via R3 source path validation bypass using symlinks
• d53 · 🟡 MEDIUM   · src/xorl/server/orchestrator/request_processor.py:555 · Arbitrary file deletion via R3SourceFilesCleanup using attacker-controlled paths
• d54 · 🟡 MEDIUM   · src/xorl/server/runner/model_runner.py:2893 · Unsafe deserialization of PyTorch files via torch.load from an environment-...
• d55 · 🟡 MEDIUM   · src/xorl/server/runner/runner_dispatcher.py:1499 · Unsafe deserialization via torch.from_file of attacker-controlled file path...

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.2) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.