Update XoRL submodule branches and SGLang pin - #41
Conversation
Broly Security ScanNote ✅ Clean scan Note Re-scan this PR anytime with
|
qywu
left a comment
There was a problem hiding this comment.
LGTM. Both gitlinks resolve to objects that exist on the live remotes (xorl-client 2a3a60a7, xorl-sglang 1fc3396a — "Reject invalid exact GLM LoRA scaling"), and declaring branch = main in .gitmodules only affects submodule update --remote, so the immutable pins still govern checkout.
Worth noting this is the only PR in the current stack that lint CI has actually run on: .github/workflows/lint.yml triggers on pull_request: branches: [main], and #42–#52 all target intermediate branches. Widening that to branches: ['**'] would be a one-line change and would have caught real ruff-format failures on #50, #51, and #52.
|
Superseded by #57, which consolidates the complete exact trainer-serving stack directly onto main. |
Summary
mainas the tracked branch forxorl-clientandxorl-sglang.xorl-clientpin at2a3a60a783c98e2a8ff722bad06dab18caee350c.xorl-sglangto the final exact-serving PR Drop internal-only cross-references from the public tree #15 head at1fc3396aa122e0f8eb7b1ea4fe0051250cf1bc3c.The parent repository continues to pin immutable commits; branch metadata only makes future submodule updates explicit.
Stack and validation
main762205400ad0b136817c3a3f6658f39500d2ded12a3a60a783c98e2a8ff722bad06dab18caee350c, and xorl-sglang resolves to1fc3396aa122e0f8eb7b1ea4fe0051250cf1bc3c.git diff --checkpassed.