Repository navigation
refactor: make millisecond units explicit in time parameter names - #552
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b0d41c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Antoliny0919
force-pushed
the
issue-536
branch
from
October 4, 2026 15:07
51b6c6a to
d7500d9
Compare
Contributor
Author
|
I think it would be helpful to have CI run against v1-base as well. index cb92b28..861655c 100644
--- a/.github/workflows/integration.yml
+++ b/.github/workflows/integration.yml
@@ -2,11 +2,9 @@ name: Integration
on:
push:
- branches:
- - main
+ branches: [main, v1-base]
pull_request:
- branches:
- - main
+ branches: [main, v1-base]
jobs:
quality:How about adding the configuration above for now and removing it after the v1 migration? |
1 of 4 tasks
Member
great thought 👍 I will do this |
Antoliny0919
force-pushed
the
issue-536
branch
from
October 6, 2026 16:47
a15da82 to
6ab60a6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1-base #552 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 2288 2288
Branches 735 735
=========================================
Hits 2288 2288 🚀 New features to boost your workflow:
|
Antoliny0919
force-pushed
the
issue-536
branch
from
October 8, 2026 05:44
e9200e8 to
3efb689
Compare
Contributor
Author
|
Once this work is complete, please assign this issue to me! -> #538 |
hyesungoh
approved these changes
Oct 8, 2026
hyesungoh
left a comment
hyesungoh
left a comment
Member
There was a problem hiding this comment.
looks great! 👍 please check below comments 👍
| 'react-simplikit': major | ||
| --- | ||
|
|
||
| Renamed time related options and parameters to include Ms, making their units clearer and naming more consistent. |
Member
There was a problem hiding this comment.
what about list up breacking changes? 🤔
Suggested change
| Renamed time related options and parameters to include Ms, making their units clearer and naming more consistent. | |
| Time-related options and parameters now include `Ms` in their names. | |
| These option keys are renamed, so existing calls need to be updated: | |
| - `useDebouncedCallback`: `timeThreshold` → `debounceMs` | |
| - `useThrottledCallback`: `timeThreshold` → `throttleMs` | |
| - `useImpressionRef`, `ImpressionArea`: `timeThreshold` → `timeThresholdMs` | |
| - `useLongPress`: `delay` → `delayMs` | |
| - `useAvoidKeyboard`: `transitionDuration` → `transitionDurationMs` | |
| ```ts | |
| // before | |
| useDebouncedCallback({ onChange: setQuery, timeThreshold: 300 }); | |
| // after | |
| useDebouncedCallback({ onChange: setQuery, debounceMs: 300 }); | |
| ``` | |
| The positional `wait` parameter of `useDebounce`, `useDebouncedValue`, `useThrottle` and `useThrottledValue` is now `debounceMs` / `throttleMs`. Calls like `useDebounce(fn, 300)` keep working. |
Contributor
Author
There was a problem hiding this comment.
I completely agree! 👍👍⭐️⭐️
hyesungoh
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes: #536
Add units to time related option names to make their meaning clearer.
Components
timeThreshold→timeThresholdMsHooks
delay→delayMsdelay→delayMstimeThreshold→debounceMswait→debounceMswait→debounceMswait→throttleMswait→throttleMswait→throttleMstransitionDuration→transitionDurationMsdelay→delayMsChecklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?