#256: drop the stale --XFAIL-- from 030-submit_closure_class_return_type - #259
Merged
Conversation
The section predicted a use-after-free when a Closure is returned from a worker. The test passes: 20 runs of 20, and three under valgrind with no invalid read. While the section stood, the suite reported a warning on every run and a real regression in that path would have been recorded as an expected failure.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #256.
The
--XFAIL--on030-submit_closure_class_return_typepredicted a use-after-free inasync_thread_create_closurewhen a Closure is returned from a worker. It does not happen: the test passes 20 runs of 20, and three runs under valgrind report no invalid read.While the section stood, every suite run printed a warning, and a real regression in that path would have been recorded as an expected failure and gone unnoticed.
Removing it is the whole change.
tests: 1192 passed, 0 failed, 0 warned.Build: ZTS DEBUG, TrueAsync ABI v0.24.0.