Skip to content

#256: drop the stale --XFAIL-- from 030-submit_closure_class_return_type #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EdmondDantes merged 1 commit into from
Aug 20, 2026
Merged

#256: drop the stale --XFAIL-- from 030-submit_closure_class_return_type #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions tests/thread_pool/030-submit_closure_class_return_type.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,5 @@
--TEST--
ThreadPool: closure with class-name return type (regression: arg_info[-1].type not deep-copied)
--XFAIL--
Returning a Closure from a worker thread is not yet implemented.
The worker creates a per-result closure snapshot in closure_transfer_obj
(TRANSFER branch), but the result-closure's persistent shell ends up
referencing memory in the task snapshot arena, which the worker frees
in thread_pool_worker_handler before the main thread loads the result.
This causes a heap-use-after-free in async_thread_create_closure when
iterating bound_vars on the loading side. Proper support requires the
result-closure snapshot to own its own arena and outlive the task
snapshot until the loading thread consumes it.
--SKIPIF--
<?php
if (!PHP_ZTS) die('skip ZTS required');
Expand Down
Loading