fix: Replace VLAs with std::vector in C++ Huffman Code - #33
Conversation
The huffmanCodes.cpp script previously used C-style Variable Length Arrays (VLAs), which are non-standard in C++ and can cause segfaults or undefined behavior. This commit replaces those VLAs with memory-safe std::vector<int> implementations. Function signatures were updated to take std::vector references instead of pointers, and outdated size calculations have been removed. Additionally, resolved signed/unsigned comparison warnings in the output loops. Co-authored-by: tsainez <13399044+tsainez@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This pull request replaces the non-standard C-style Variable Length Arrays (VLAs) in
c++/huffmanCodes.cppwith standardstd::vector<int>.The author of the code noted that the previous array initialization (
int arr[n];) caused segmentation faults. This is because dynamically allocating variable-length arrays on the stack is not standard C++ and can lead to stack overflows or compiler issues depending on the extensions supported by the compiler used.Changes made:
int arr[n]andint bits[n]withstd::vector<int> arr(n)andstd::vector<int> bits(n).huffmanEncode,traverse, andprintBitsto useconst std::vector<int>&where applicable to avoid unnecessary copies while providing the array data to helper functions.sizeof(arr) / sizeof(arr[0])).int jtosize_t jin the loop condition inmainto address signed/unsigned comparison warnings against.size().Tested locally by providing an input set and verifying output encoded binaries remain correct.
PR created automatically by Jules for task 3341179921368451821 started by @tsainez