Skip to content

fix: Replace VLAs with std::vector in C++ Huffman Code #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsainez wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Replace VLAs with std::vector in C++ Huffman Code #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 6 additions & 19 deletions c++/huffmanCodes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ struct Min {
}
};

void printBits(int* b, int location, int tmp) {
void printBits(const vector<int>& b, int location, int tmp) {
globalBits.push_back(-1); // '-1' is a placeholder, see below
// The algorithm actively searches for '-1' tokens
globalBits.push_back(tmp);
Expand All @@ -55,7 +55,7 @@ void printBits(int* b, int location, int tmp) {
globalBits.push_back(b[i]);
}

void traverse(Node* root, int* arr, int location) {
void traverse(Node* root, vector<int>& arr, int location) {
// This function places 0 or 1 into the array depending on if you are
// travelling left or right on the tree, and will print out the binary
// code if the node is a leaf.
Expand All @@ -80,7 +80,7 @@ void traverse(Node* root, int* arr, int location) {
}
}

Node* huffmanEncode(int* arr, int n) {
Node* huffmanEncode(const vector<int>& arr, int n) {
priority_queue<Node*, vector<Node*>, Min> minPriorityQueue;

for(int i = 0; i < n; i++)
Expand Down Expand Up @@ -109,29 +109,16 @@ int main() {
int n;
cin >> n;

// You cannot declare the array in any other way,
// for some reason it causes a segfault or it will
// simply not yield the correct test results. Not sure
// as to why this is the case. Really odd bug.
int arr[n];
vector<int> arr(n);
int counter = 0;

for(int i = 0; i < n; i++) {
cin >> arr[i];
counter++;
}

int size = sizeof(arr) / sizeof(arr[0]);

/*
if (size != n) {
cout << "Something went wrong. Dying!";
return 0;
}
*/

Node* root = huffmanEncode(arr, n);
int bits[n];
vector<int> bits(n);
int leaf = 0;

// We gotta fill the tree, so we traverse it.
Expand All @@ -153,7 +140,7 @@ int main() {
// Now we can ascertain to where the exact match is.
match = distance(globalBits.begin(), it) + 1;

for(int j = match; j < globalBits.size(); j++) {
for(size_t j = match; j < globalBits.size(); j++) {
if(globalBits[j] == -1) {
end = j;
globalBits.erase(globalBits.begin() + match - 2,
Expand Down