docs+test: document prerequisites and add 125%-DPI reference goldens - #56
Merged
Conversation
Add a Dependencies & prerequisites section listing the .NET SDK, MAUI workloads, Android SDK/JDK, Windows SDK, Node/Appium versions plus key NuGet packages and the environment variables needed to build, test and pack from a clean machine. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PixelDiffTests resolves References/dpi-{N}/{id}.png by GetDpiForWindow. Only dpi-96 was committed, so on 125%-scale machines the suite silently regenerated references and skipped comparison. Add the six dpi-120 goldens (~1.25x the dpi-96 pixel dimensions) so 125%-DPI runs get real pixel-diff coverage. Additive only: CI runs at 96 DPI and never loads these.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two loose ends left uncommitted at the end of the interaction-controllers refactor arc (PR #40).
1.
docs: build/test/pack prerequisites in AGENTS.mdAdds a Dependencies & prerequisites section: .NET SDK (pinned via
global.json), MAUI workloads, Android SDK/JDK 17, Windows 10 SDK, Node/Appium, key NuGet packages, and the env vars (JAVA_HOME,UITEST_APP_PATH,ColorPickerVersion,PROBE_OUT) needed to build from a clean machine.2.
test: 125%-DPI (dpi-120) pixel-diff reference goldensPixelDiffTestsresolvesReferences/dpi-{N}/{id}.pngviaGetDpiForWindow. Onlydpi-96was committed, so on 125%-scale monitors the suite silently regenerated references and skipped comparison. This adds the sixdpi-120goldens (~1.25x the dpi-96 pixel dimensions — genuine 125%-DPI captures) so those runs get real pixel-diff coverage.Additive & CI-safe: CI runs at 96-DPI and never loads these files; the missing-reference path already auto-passes.