Skip to content

Prevent X11 terminal bell crash after connection loss - #52

Draft
warp-agent-staging[bot] wants to merge 1 commit into
factory/benchmark-base-winit-wm-hintsfrom
factory/update-winit-wm-hints
Draft

warp-agent-staging[bot] wants to merge 1 commit into
factory/benchmark-base-winit-wm-hintsfrom
factory/update-winit-wm-hints

Conversation

@warp-agent-staging

Copy link
Copy Markdown

Description

Pins winit to warpdotdev/winit#30, where X11 request_user_attention no longer panics if sending WM_HINTS fails after the connection dies. This prevents an inactive terminal bell from aborting Warp on Linux/X11.

Linked Issue

No linked issue was provided for this benchmark task.

  • The linked issue is labeled ready-to-spec or ready-to-implement — no linked issue
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes) — the failure requires a dead X connection and has no stable rendered state

Testing

  • cargo check -p warpui

  • cargo clippy -p warpui --all-targets --tests -- -D warnings

  • ./script/format

  • The pinned winit revision passed its X11-only tests and Clippy checks in the upstream change.

  • I have manually tested my changes locally with ./script/run — the dead-connection failure is not safely reproducible through the running app

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Prevented a crash when the terminal bell rings after the X11 connection closes.

@warp-agent-staging

Copy link
Copy Markdown
Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation

@warp-agent-staging
warp-agent-staging Bot changed the base branch from master to factory/benchmark-base-winit-wm-hints September 25, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants