Prevent X11 terminal bell crash after connection loss - #52
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Author
|
This PR was generated with Warp. Comment |
5 tasks
warp-agent-staging
Bot
changed the base branch from
master
to
factory/benchmark-base-winit-wm-hints
September 25, 2026 13:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Pins winit to warpdotdev/winit#30, where X11
request_user_attentionno longer panics if sendingWM_HINTSfails after the connection dies. This prevents an inactive terminal bell from aborting Warp on Linux/X11.Linked Issue
No linked issue was provided for this benchmark task.
ready-to-specorready-to-implement— no linked issueTesting
cargo check -p warpuicargo clippy -p warpui --all-targets --tests -- -D warnings./script/formatThe pinned winit revision passed its X11-only tests and Clippy checks in the upstream change.
I have manually tested my changes locally with
./script/run— the dead-connection failure is not safely reproducible through the running appAgent Mode
CHANGELOG-BUG-FIX: Prevented a crash when the terminal bell rings after the X11 connection closes.