Skip to content

Do not panic when sending X11 WM hints fails - #30

Draft
warp-agent-staging[bot] wants to merge 1 commit into
warpdotdev/v0.30.xfrom
factory/recover-wm-hints-send
Draft

warp-agent-staging[bot] wants to merge 1 commit into
warpdotdev/v0.30.xfrom
factory/recover-wm-hints-send

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Prevents X11 request_user_attention from panicking when WmHints::set cannot send because the X connection has died. Successful sends continue to discard the asynchronous cookie without checking it.

Warp consumes this revision in warpdotdev/warp-for-benchmarks#52.

  • Tested on all platforms changed — cargo test --no-default-features --features=x11
  • Added an entry to the changelog module if knowledge of this change could be valuable to users — internal error-handling fix only
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior — no API or documented behavior changes
  • Created or updated an example program if it would help users understand this functionality — not applicable to a dead-connection error path
  • Updated feature matrix, if new features were added or implemented — no feature change

Validation

  • cargo test --no-default-features --features=x11
  • cargo clippy --all-targets --no-default-features --features=x11 -- -Dwarnings
  • cargo fmt

A focused automated regression test would require a real X server connection that is terminated during the request or a production-only connection seam, so this change relies on the X11 compile/test coverage above.

@warp-agent-staging

Copy link
Copy Markdown
Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants