fix(podspec): recursive ** framework search path on Unity macOS + Unreal iOS - #4
Merged
Merged
Conversation
… unreal iOS PR #3 fixed this for the Unity iOS podspec: Xcode does not expand a single '*' in FRAMEWORK_SEARCH_PATHS, so 'plugins/*/<platform>' never resolves the vendored engine framework for hosted (pub.dev) / standalone installs. The Unity macOS and Unreal iOS podspecs still used the single-'*' form; switch them to Xcode's recursive '**' to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3, which fixed the Unity iOS podspec's
FRAMEWORK_SEARCH_PATHSto use Xcode's recursive**glob. That fix was only applied to one of the engine podspecs the Unity macOS and Unreal iOS podspecs still used the single-*form (.symlinks/plugins/*/<platform>), which has the identical bug.Xcode does not expand a single
*inFRAMEWORK_SEARCH_PATHS, soplugins/*/macos(andplugins/*/iosfor Unreal) never resolves the vendored engine framework for hosted (pub.dev) / standalone-app installs — it only worked when a symlink happened to be planted in the pod's own dir. Switching to**searches all subdirectories under the plugins symlink dir, matching the merged Unity-iOS fix.Changes
engines/unity/dart/macos/gameframework_unity.podspec:plugins/*/macos→plugins/**engines/unreal/dart/ios/gameframework_unreal.podspec:plugins/*/ios→plugins/**Comments updated to match the explanation already in the Unity iOS podspec.
Notes
packages/gameframeworkpodspecs are unchanged.FRAMEWORK_SEARCH_PATHSentry, so it's out of scope here.