Repository navigation
preserve order of ports in PortsList. Solves issue #851 - #870
Closed
facontidavide wants to merge 1 commit into
Closed
facontidavide wants to merge 1 commit into
facontidavide wants to merge 1 commit into
Conversation
Collaborator
Author
|
Unfortunately, if I merge this, I need to create BT.CPP 5.0, because EVERYONE will be obliged to recompile their applications. Still unsure what to do |
Collaborator
Author
|
Closing in favor of #1260. Changing |
facontidavide
added a commit
that referenced
this pull request
Oct 26, 2026
PortsList is an unordered_map, so writeTreeNodesModelXML() emitted the ports in hash order, which differs across builds and shows up in Groot2. Sort them by direction (input, output, inout), then by name, as was done before d5ea17b. Keeping the order of providedPorts() would need to change the PortsList type (#870), which breaks API/ABI; this is the compatible subset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check is probably NOT binary compatible, nor API compatible