Repository navigation
feat(MigrationMetadata): AppliedStereotype records a source stereotype the v2 form does not carry - #5
Conversation
…e the v2 form does not carry The SysML v1 migrator writes it on an element whose v2 form is the stereotype's (a dependency for a «Trace») or whose stereotype comes from a profile it did not write; tags keeps the tag values no v2 feature holds. Co-Authored-By: jason.han <hanhuijun@gmail.com>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
The required job (
The coordinated OpenSysML PR is Open-MBEE/OpenSysML#1043 (branch |
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
Summary
Adds one metadata def to
libraries/MigrationMetadata.sysml:The SysML v1 migrator writes it on an element whose v2 form is the stereotype's own form and therefore cannot name the stereotype — a dependency is a «Trace»'s v2 form, so the migrator writes
@AppliedStereotype { stereotype = "Trace"; }on it — or whose stereotype comes from a profile the migration did not write (named byprofile).tagskeeps, astag = valuestrings, the tag values no v2 feature holds. LikeSynthesizedNameandStandIn, it is a record of the migration, not model content.engine-contract.jsongains the matchingMigrationMetadata::AppliedStereotypeentry (kindmetadata, attributesstereotype/profile/tags,migratorEmitted: true), since OpenSysML binds the name ininternal/semantic/semantics/synthesized_name.goandinternal/translate/migrate/migrate.go.Semver impact: MINOR (a new element; no existing entry changes, so
contractstays at its current value).Checks:
./scripts/validate-libraries.sh(0 errors, 0 warnings),./scripts/check-engine-contract.sh --base origin/main,./scripts/check-readme-table.shand./scripts/build-kpar.pyall pass.OpenSysML will re-pin its vendored
OpenSysML Libraries/copy to themaincommit this merges as.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/1927cf08c2b9400b8a4c522dde258549
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/1927cf08c2b9400b8a4c522dde258549?variant=devin
Requested by: @HuiJun