Add cashier owner approval and saved bill recovery - #1014
Closed
sridharkalaibala wants to merge 1 commit into
Closed
sridharkalaibala wants to merge 1 commit into
sridharkalaibala wants to merge 1 commit into
Conversation
This was referenced Sep 28, 2026
Contributor
Author
|
The complete Business companion stack, including this change, is integrated into develop through #1023. All checks, including CodeQL, passed before merge. Closing this superseded stacked PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cashiers can request owner approval from the bill, see the current decision and save only after an explicit action. Interrupted requests recover by operation ID; an uncertain save requires a fresh receipt check, and an existing saved bill is recovered with its original operation ID. Local reconciliation takes precedence over an approved status, preventing the dialog from offering another save.
Adds scoped capability and operation lookup, bounded local journal indexes, accessible cashier controls and 18 language packs for this dialog. Existing on-site manager approval remains available for unsupported bills. Stacked on #1013. The production decision flag remains disabled pending unresolved-receipt operator handling, broader bill combinations and native release qualification.
Validation: full desktop run 3,488 passed, four skipped and two failures (README route count and punctuation); both failures corrected and all 32 targeted checks passed, including eight cashier/translation tests. API regression 232 passed, real MongoDB checkout/outbox eight passed, Gateway contract seven passed and route/auth boundary 30 passed. Frontend bundle, language coverage, attribution and relevant formatting/lint checks passed (existing controller lint warnings remain). Chromium fixture checks passed at narrow widths, Arabic RTL and 200% text. These are local fixture results, not deployed or physical-device acceptance.