[Birfy]

Written-by: Dev

Owner: Dev
Reviewer: Reviewer

Fixes #1113

What changed

Once Auto-send is on for a pair (the card's Auto-send from now on, or Sharing → People with access), an ordinary later group line to that friend's Bot no longer stops on Waiting for approval. Bot Social holds those room envelopes as policy when the text merely looks like injection, and its own auto-approve refuses them. FlyBot now clears that room hold (roomPolicyClears on autoSendRoomEnvelope, and the same clear on the next poll when the list lagged). An instruction-override, a DLP reason, a risk flag, a file, and the same policy hold on a direct message still wait. Blanket room clears with Auto-send off stay as they were.

docs/subsystems/social.md (invariant 9, Auto-send per pair, inbound shared groups). changelog.d/1113.fixed.md.

Verification at the tip

Tip SHA: fcc3fadcad4d3784877905befab4dfb8d7ab8fcb

Fail-without-change, base 199b9bc7cc8b930e76351d32d221578381c4abd0, production social.js unchanged:
TZ=UTC node --import ./test/resolve.mjs --test --test-name-pattern '#1113' test/social.test.js in plugins/social — 4 tests, 2 pass, 2 fail. The ordinary group line timed out in waitUntil (the queue never emptied). The lagged-list poll left server.queue.length at 1. The instruction-override, direct-message, DLP, risk, and attachment cases passed.

Ran:

• TZ=UTC npm run verify (exit 0, 39s) on this tree before the commit (the same four files). core 1449 pass, plugins/social 485, plugins/tree 125, plugins/timeline 125, .github/scripts 417, interop 37, live-e2e 16. Core lint and plugin lint exited 0. build-client.mjs --check and ds-bot-patches.mjs check exited 0.
• node core/scripts/check-arch-docs.mjs at fcc3fad: arch-docs: OK (4 changed file(s)).

Not run: smoke (core/index.js and core/src/host/ untouched). Not enqueued.

git diff origin/main...HEAD --stat lists only changelog.d/1113.fixed.md, docs/subsystems/social.md, plugins/social/src/social.js, plugins/social/test/social.test.js.

  

[Birfy]

Verdict: PASS at fcc3fad

Written-by: Reviewer

Read the tip on fcc3fad (parent is main; four files: social.js, social.test.js, docs/subsystems/social.md, changelog.d/1113.fixed.md). Nothing deleted outside that set.

What the change does: once pair Auto-send is on, autoSendRoomEnvelope(sent, { pair }) also clears a room policy hold that roomPolicyClears accepts — blanket reasons only, no risk flags, no attachments, and the text is not an instruction-override pattern. Ordinary words that Bot Social treats as injection (e.g. "token") stop looping the Group update card. A lagged list_approvals is finished on the next poll via clearLaggedRoomHolds. Direct messages stay on holdIsBlanket alone; DLP, risk, files, and instruction-override still wait. Blanket clears with Auto-send off are unchanged.

Ran:

• node .github/scripts/changelog.mjs check → 29 fragment(s) well formed (changelog.d/1113.fixed.md present).
• node scripts/ds-bot-patches.mjs check → ok 10 patches; core/ equals ds-bot + patches (this PR does not touch core).
• node core/scripts/check-arch-docs.mjs → arch-docs: OK (4 changed file(s)).
• CI at fcc3fadcad4d3784877905befab4dfb8d7ab8fcb: plugins (social) pass, plugins (tree/timeline) pass, ubuntu-latest · Node 24 · DSH pass, package / merge-gate / agent-audience / risk tier / reviewed tip — success. enqueue-guard is red until this verdict names the tip.

Fail-without-change evidence is in the PR body (base 199b9bc, two #1113 reds for the ordinary group line and lagged poll). Ghost check: pulls/1117/files adds no deletes outside the four paths.