[Birfy]

Written-by: Dev

Owner: Dev
Reviewer: Reviewer

Fixes #1167

What changed

Removing a friend's Bot from an ordinary shared group marked the seat left and only then sent op: leave. Reach and a room link's pairs only see current members, so that leave was refused. The other home kept the room and could still send, and a later line or an in-flight join cleared the hide and brought the room back.

The leave now goes out while the seat is still live. The guest mirror stays hidden: a later line is refused, a join that is not newer than the leave does not reopen it, and the hidden mirror sends nothing. A newer join, the Bot added again, opens the room.

Verification at the tip

Tip SHA: 1debb12dc0a1d2e40d527f0ae62f467a1ff55ae2

Ran (TZ=UTC, Node v22.23.4):

• On the unfixed tip, node --import ./test/harness-resolve.mjs --test --test-name-pattern '#1167' core/test/remote-room.test.js failed: the leave was deny rather than allow, and a line after the leave was not refused as left.
• npm run verify at this tip, exit 0. Core lint and arch-docs OK. build-client.mjs --check and ds-bot-patches.mjs check OK. Core tests 1512 pass, social 522, tree 125, timeline 125, .github/scripts 427, interop 37, live-e2e 16. All fail 0.
• node .github/scripts/changelog.mjs check OK.
• node core/scripts/check-arch-docs.mjs on this commit: OK (9 changed files).

Not run: the smoke bench (dev/bench.sh). src/host/room-membership.js changed, and there is no deepseek-harness checkout beside this repo for the bench to start.

No deploy.

  

[Birfy]

Verdict: PASS at 1debb12
Written-by: Reviewer
Attestation: 1debb12 role=Reviewer

Ran:

• git rev-parse HEAD → 1debb12
• git fetch origin main && git diff origin/main...HEAD --stat → 9 files (room-membership, its tests, core-host.md, changelog fragment, generated patches)
• TZ=UTC node --import ./test/harness-resolve.mjs --test --test-name-pattern 'Removing a member's Bot from a shared group leaves that home still seeing the room #1167|A group joined by link is listed as "Shared room from Ann" instead of its own name #892: withdrawing' test/remote-room.test.js test/room-ticket-seat.test.js → fail 3/3 on merge-base 1581a5d core/src/host/room-membership.js with the tip tests (defect test). Leave reach was deny, a line after the leave was not refused as left, and the removed guest still sent. Source restored to the tip before the green run; git status clean.
• TZ=UTC npm run verify → pass (Node v22.23.4). arch-docs OK (9 files). build-client --check and ds-bot-patches check OK. Core 1512 pass, social 522, tree 125, timeline 125, .github/scripts 427, interop 37, live-e2e 16. Fail 0. Both Removing a member's Bot from a shared group leaves that home still seeing the room #1167 tests and the A group joined by link is listed as "Shared room from Ann" instead of its own name #892 guest-send assertion passed in this run.
• TZ=UTC node .github/scripts/changelog.mjs check → pass (50 fragments)
  Not run:
• smoke bench (core/dev/bench.sh) — core/src/host/room-membership.js changed; no deepseek-harness checkout beside this repo
• Desktop and a real-model steward
• CI package job (typecheck, actionlint, pack) — npm run verify does not run it

No actionable findings at 1debb12. Leave is sent while the seat is still reachable; remote hides the room and refuses later lines. Defect tests fail on the unfixed merge-base. Tier T3. Author-login PASS attested for tip (Attestation line).