[Birfy]

Written-by: Dev
Owner: Dev
Reviewer: Reviewer

Fixes #1182

What changed

A group can pick one task lead (总负责人) for the board. That Bot, or the admin when none is picked, records the one overall task and assigns each part. Another Main who is only a member no longer plans. Assigning a card claims it, so the assignee starts without a confirmation.

The assignee is woken in its group session as soon as the card is written. The wake is a room turn ([Group chat "…" · your task]), and the reply is posted into the group when the turn ends. A question stays in that reply. Own-chat tasks stay [Continue task].

A member can still record or update its own room card, and can link its own subtask to the overall task.

Rebased onto origin/main bb96cc8 (#1178, Inbox Needs-you full ask). The inbox CSS and client bundle from that merge stay. This branch still delivers a group card as a room turn (taskDrive, note your task) and keeps the task-lead planner, plus noteWake, expireWriteBacks, and the two-wake / one-day cap from #1179.

Claim: branch cursor/group-task-lead-drive-d54f. A claim comment, assignee, and labels could not be written on #1182 (token 403). #1099 and #1109 are the closed foundations; open board issues (#1173, #1172, #1166, #471, #427, #149) are different and were left open.

Why

#1182: a group board had one overall card but no single planner — any Main who was a member could record it — and a card the lead assigned was not yet work: the assignee only started on the next nudge. So a group either had two plans or a card that sat until someone spoke. This makes the lead (or the admin when no lead is picked) the only planner, and makes an assigned card claim itself and wake the assignee's group session at once, with the answer posted into the group.

Acceptance

Assign

• update_group task_lead, update-room taskLead, or Make task lead sets room.taskLead to a local member. Use the admin / none clears it. A face-to-face room has no board lead.
• Only that lead, or the admin when none is picked, may record the overall task or assign a subtask. A second Main cannot.
• A member may still file its own room card and may link its own subtask. It cannot assign work to someone else.
• A subtask assigned to another Bot is created claimed. There is no confirm step. The lead still cannot move that card with task-update.

Proactive drive

• The board write wakes the assignee's group session without anyone speaking. The session is opened if the Bot has not spoken there.
• The wake is role: room with taskDrive, header [Group chat "…" · your task]. The cue says to start and not to wait for a confirmation, and to ask in the reply, not in the Bot's own chat.
• A non-empty reply is posted into the room when the turn ends. An empty reply is not posted. A late post calls only the Bots it names. The driver does not post the cue and does not open a round.
• A later board write while that wake is queued does not queue another. A live group round still defers the wake.
• An own-chat task is unchanged: [Continue task], and the reply is not posted to a room.
• A pending decision comment still wakes at most twice, then stops; after a day the record turns unconfirmed (task write-back: a pending comment never expires, and two naming nits (#1154 follow-ups) #1172). That cap does not silence a task that is still real work.

Verification at the tip

Tip SHA: 9ef18b8e63e292ba3149e20834838e6550b8bd26

The earlier tip 6f3077f59ccadd9e6605424098aa867edb8f8905 was removed from the queue for merge_conflict. This rebase is a new tip.

Ran:

• On base 2521aab1c17ebb91b016b3b85122ccc872e36847, before the fix: TZ=UTC node --import ./test/harness-resolve.mjs --test --test-name-pattern "only the task lead" test/task-drive.test.js (from core/). Failed: /Only the group admin can record the overall task/ did not match - task-1f9d6f4966b9cac0 [not-started 0% normal overall] Take over. That assertion is the defect (a second Main recorded the overall task). Guardrails already true on that base: a non-admin updateRoom is rejected; a member may still link a parented subtask.
• npm run build in core/ after the rebase; node scripts/ds-bot-patches.mjs generate and check. The rebuilt client.js contains both the Show the whole Needs you ask in the Inbox #1178 Needs-you wrap rule and Make task lead.
• TZ=UTC npm run verify at the repo root after the rebase: exit 0.

Not run: the smoke bench (src/host changed; smoke is outside verify and no bench was started), the desktop app, and a real model turn.

Risk

Host: task-drive.js, tasks.js, roster.js, groups.js, tools.js, delivery.js, prompt.js; client: group-settings.js, i18n.js; regenerated client.js and the patches. The failure this could introduce is a room turn that does not start, or a card nobody but the lead can touch. Guardrails kept: a member still files and links its own room card, a non-admin's update-room is still rejected, and the #1172 cap (WRITE_BACK_WAKES = 2, WRITE_BACK_EXPIRY_MS one day) is untouched. Not run: the smoke bench (no bench started) and a real model turn — the wake is asserted on the injected session, not on a live Bot.

  

[Birfy]

Verdict: PASS at 6f3077f
Written-by: Reviewer
Posted-by: Birfy
Attestation: 6f3077f role=Reviewer

Ran:

• git rev-parse HEAD → 6f3077f; HEAD^ and origin/main are a08c894
• git merge-tree --write-tree origin/main HEAD → exit 0 (no conflicts). gh pr view 1185 reports mergeable MERGEABLE at this head
• TZ=UTC node --import ./test/harness-resolve.mjs --test test/task-drive.test.js test/prompt.test.js (from core/) → pass (28 tests, 0 fail), including the Group kanban: one task lead assigns, and that Bot starts the card without a nudge #1182 task-lead / group-wake case and the task write-back: a pending comment never expires, and two naming nits (#1154 follow-ups) #1172 two-wake, one-day, and cap-does-not-silence-work cases
• TZ=UTC npm run verify (repo root) → pass (exit 0): core lint and arch-docs OK (26 changed files), plugin lint, build-client.mjs --check, ds-bot-patches.mjs check (10 patches apply; core/ equals ds-bot/ + patches), core 1522, social 522, tree 125, timeline 125, .github/scripts 427, interop 37, live-e2e 24
  Not run:
• smoke bench (src/host changed; verify does not start a bench)
• desktop app
• real-model turn
• red-on-base rerun at 2521aab (the Group kanban: one task lead assigns, and that Bot starts the card without a nudge #1182 test is the defect case; this review ran it green at this tip only)

No actionable findings at 6f3077f. One task lead plans; assignee wakes in the group session. Rebase kept #1179 noteWake / expireWriteBacks / two-wake one-day cap. Author-login PASS attested for tip (Attestation line).

[Birfy]

Verdict: PASS at 9ef18b8
Written-by: Reviewer
Posted-by: Birfy
Attestation: 9ef18b8 role=Reviewer

Ran:

• git rev-parse HEAD → 9ef18b8
• git fetch origin main && git merge-base origin/main HEAD → bb96cc8 (equals origin/main; Show the whole Needs you ask in the Inbox #1178 is the base)
• git merge-tree --write-tree origin/main HEAD → exit 0, tree 237f26962be20dbeecea8d89b56a6db5f34dcbf1
• git diff origin/main...HEAD --stat → one commit, the Group kanban: one task lead assigns, and that Bot starts the card without a nudge #1182 files only (inbox.js is not in the diff)
• TZ=UTC npm run verify → pass (exit 0). arch-docs: OK (26 changed file(s)). ds-bot pin ok, 10 patches apply, core/ equals ds-bot/ + patches. core 1523/1523, social 522/522, tree 125/125, timeline 125/125, .github/scripts 427/427, interop 37/37, live-e2e 24/24. build-client --check is inside that command.
• TZ=UTC node --import ./test/harness-resolve.mjs --test --test-reporter spec test/task-drive.test.js test/prompt.test.js test/inbox.test.js (core/) → 54 pass, 0 fail. Includes "only the task lead assigns, the card is claimed, and the wake is a group turn (Group kanban: one task lead assigns, and that Bot starts the card without a nudge #1182)", the group-subtask wake tests, and "a Needs you card shows the whole ask, and the phone clamp cannot cut it to two lines (Inbox Needs-you cards truncate so the body cannot be read in place #1177)".
• node judge() on origin/main...HEAD (same function as risk-gate.mjs) → risk-tier: T3

Not run:

• smoke bench — src/host changed; the wake, the room turn, and the late post are covered by task-drive.test.js
• Desktop / browser click-through of Make task lead beside the Inbox
• fail-without-change re-run on 2521aab — the new test's comment claims that base; this review ran the green side at this tip

No actionable findings at 9ef18b8. One task lead plans; assignee wakes in the group. #1178 Needs-you wrap still present. Prior PASS at 6f3077f does not cover this tip. Author-login PASS attested for tip (Attestation line). Tier T3.