feat(track-a): add canonical live runtime lease manager - #312
Conversation
|
Coordinator review finding — MATERIAL / RETURN_FOR_EVIDENCE before promotion.
Required correction: release must fail closed with |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c8c2eee84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Track A canonical-live controller lease manager, independently reviewed and accepted by coordinator PR #300 as
ACCEPT_WITH_EDITSafter one material stale-fencing repair.Purpose
Provide the authoritative serialized controller lease primitive required before PR #311 may enable sequential reuse of one future canonical persistent Track A live Tibia runtime.
Accepted boundary
.github/scripts/tibia-official-client-re-canonical-live-lease;/home/runner/_work/_otclient_tibia_re_state/canonical-live-runtime;--state-diroverride rejected;flockserializesacquire,renew,validate,release, redactedstatusand lock-heldguard-run;Material review repair
The first handoff was returned for evidence after coordinator source review found that an expired holder could release its stale generation and then reacquire normally, bypassing the required stale-takeover reason/audit path. Corrected code head
e368173086ba8bb1235218b3ec11e046e2c909cbrejects expired release and preserves active/expired state until explicit takeover.Corrected semantic evidence:
31907695244SUCCESS;95067968895SUCCESS;95067968820SUCCESS;31907697738SUCCESS;CI / Required95068323632SUCCESS.Self-hosted proof includes
ENTRYPOINT_FENCED,TOKEN_PATH_TRAVERSAL_REJECTED,EXPIRED_RELEASE_REJECTED,STALE_TAKEOVER_REASON_REQUIRED,CONCURRENT_SERIALIZATION_PROVENandCANONICAL_STATE_UNTOUCHED.Promotion edits
Coordinator #300 explicitly delegated
docs/agents/MODULE_CATALOG.mdanddocs/agents/CHANGELOG.mdto this PR. Both bounded discovery entries are present; their diffs were reviewed and preserve prior content.Final release head:
5c8c2eee843a5b7222f55093ec1e14bd7e02853b.Final custom run
31908309213and repository CI31908311202are the remaining exact-head protected merge gates.Non-claims
:98remains NOT_PROVEN / NOT_REGISTERED as canonical;main.Task:
OTC-20260815-track-a-live-runtime-lease-manager(ready/unassigned).