fix(assets): select release archives by client version - #37
Merged
Conversation
This was referenced Jul 26, 2026
blakinio
force-pushed
the
fix/OTC-20260726-client-assets-release-selection
branch
from
July 27, 2026 07:06
070a1d8 to
2ae0aa8
Compare
blakinio
marked this pull request as ready for review
July 27, 2026 07:07
blakinio
force-pushed
the
fix/OTC-20260726-client-assets-release-selection
branch
4 times, most recently
from
July 27, 2026 10:21
ef4814c to
b04c6d3
Compare
Owner
Author
|
Coordinator preflight against current |
This was referenced Jul 28, 2026
blakinio
force-pushed
the
fix/OTC-20260726-client-assets-release-selection
branch
4 times, most recently
from
July 29, 2026 08:53
b90881d to
b2c45e1
Compare
blakinio
force-pushed
the
fix/OTC-20260726-client-assets-release-selection
branch
from
July 29, 2026 09:05
b2c45e1 to
a26efb7
Compare
blakinio
enabled auto-merge (squash)
July 29, 2026 09:51
blakinio
force-pushed
the
fix/OTC-20260726-client-assets-release-selection
branch
from
July 29, 2026 10:28
a26efb7 to
94061a6
Compare
blakinio
force-pushed
the
fix/OTC-20260726-client-assets-release-selection
branch
from
July 29, 2026 10:53
94061a6 to
e02ef6b
Compare
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Prevent unrelated legacy or macOS archives from being selected by the client-assets GitHub release resolver while preserving strict hashes, standard install paths and codeload fallback.
Task
OTC-20260726-client-assets-release-selectione9bcc172f005fb9993178b17f630acf382656090e02ef6bfb806639dfb003b2dc5913327cddf2594backup/OTC-20260726-client-assets-release-selection-pre-20260729-restack-7465b7a217e87502bb7f9980bf6e099718d0a9a49Scope
LABELS "lua;unit"Verified behavior
Verified diff
Exactly nine files. No historical stack or unrelated files are included. W4 plan, Windows application shell, closure and all W4 lifecycle archives through #82 are retained from
main; only the changelog overlapped and was reconciled.Safety and blocker
Validation
Head
a26efb7af14afe39e310cb393b130d4270fc1673passed exact-head run30438208569, including all five Windows jobs, CMake Tests/CTest andCI / Requiredjob90547397445, but W4 advancedmainbefore merge.Head
94061a65d3e1d0961c9c95022c18da484788ab99started run30443793680; Fast/Lua/luacheck/cppcheck were green and the Windows matrix was active when W4 implementation/lifecycle advancedmain.A final exact-head run for
e02ef6bfb806639dfb003b2dc5913327cddf2594must pass Lua Syntax, Windows CMake Tests/CTest, the full required Windows matrix andCI / Requiredbefore squash merge.