Repository navigation
Conversation
…de#1379) * RbsCollection * Gem caching in External spec * RbsCollection specs * Stale code * Linting
The no-YARD gem mapper lost pins that YARD used to produce: * Mixins called on an explicit receiver. Only receiverless include/extend/prepend were mapped, so ActiveSupport's `Object.prepend(self)` (which is how `require_dependency` reaches every class) and `Integer.prepend ActiveSupport::NumericWithFormat` made all the methods those modules add to core classes invisible. * ActiveSupport's `class_attribute`, whose accessors are created at run time. Rails documents them with `## :singleton-method:` comment directives that YARD turned into methods. `process_class_attribute` generates the same accessors and honors instance_accessor/instance_reader/instance_writer/instance_predicate. Fixes several solargraph-rails definitions (require_dependency on ActiveJob, Rails::Application, ActionDispatch::Routing::Mapper and ActiveRecord; ActionController callbacks; ActiveRecord::Base.enumerate_columns_in_select_statements; ActiveRecord::Base#signed_id_verifier_secret; Integer#to_formatted_s).
External now selects collection entries for the gems it loads, but the lookup expected a collection directory whose version matches the installed gem. Two kinds of signature sets were silently dropped: * Gems whose signatures are published under a different version than the gem. gem_rbs_collection ships `actionpack/6.0` for every Rails 6 and 7 release and `devise/4.9` for Devise 4 and 5, so actionpack 7.0.10 and devise 5.0.4 got no signatures at all (this is what hid the ActionController callback DSL). RbsCollection#best_key now falls back to the closest version the collection provides for that gem, preferring the highest one that does not exceed it. * Stdlib entries in the lockfile (`date/0`, `json/0`, ...). They are not associated with a gem in the bundle, and `rbs collection install` resolves them to the signatures that ship with the rbs gem instead of copying them into the collection directory, so they can never be matched by a gem lookup. RbsCollection#stdlib_names exposes them and External loads them with Collection::Stdlib, which restores e.g. `Date#xmlschema -> String`. Also guards External#rbs_collection_lockfile against a nil directory, which previously short-circuited before the collection was touched.
Gem pins are mapped from gem source and serialized, so a plugin's conventions shape what lands in the gem cache. The language server caches gems by running `solargraph cache` in a subprocess, which never loaded the workspace's plugins, so the cache it wrote could differ from the one an in-process typecheck builds. `cache` and `uncache` now require the plugins configured for the directory, through a Workspace::Config#require_plugins that Workspace also delegates to. Each loaded plugin and its gem version are recorded in CacheDir, and gem_dir includes them, so loading or upgrading a plugin rebuilds the gem cache instead of reusing pins made without it. The @sg-ignore in CacheDir.add_plugin records a typecheck defect: Hash#each_value.find types the block parameter as the value type unioned with the hash itself. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EhUSLUimEYJyCZv8NdQGKb
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SEntZKsZwQHhzqcwG7MTqn
apiology
force-pushed
the
load-plugins-when-caching-gems
branch
from
October 21, 2026 16:35
fd049d2 to
2a0c289
Compare
apiology
changed the title
A plugin was recorded in the gem cache key only when the workspace config required it. A process that requires the plugin directly, such as a plugin spec suite using a workspace without config, mapped gems with the plugin loaded but read and wrote the plain gems directory, so it missed caches built by `solargraph gems` with the plugin configured. Record the gem that defines each registered convention, and key config-required plugins by gem name so both paths give the same key. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SEntZKsZwQHhzqcwG7MTqn
Keep the natural Hash iteration and mark the Solargraph gap: the each_value block param is typed as the Hash pair, not the value. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SEntZKsZwQHhzqcwG7MTqn
The parent keys gem_dir on the plugins it has loaded, while `solargraph cache` re-read the --directory config. When the two sets differ (a workspace built with another config, a plugin loaded by plain require, or several workspaces in one process), the subprocess writes its pins to a directory the parent never reads, and Library#cache_next_gemspec re-caches the gem forever. Record what to require for each plugin and pass that list with --plugins, so the subprocess loads the same set and writes to the same gem_dir. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SEntZKsZwQHhzqcwG7MTqn
Undercover flagged the block in Shell#require_plugins that requires each plugin named by --plugins: the only spec passed an empty string, so the require, CacheDir.add_plugin and LoadError branches never ran. Add specs for a loadable plugin and a missing one, and clear the plugin from CacheDir.plugin_requires after each example. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SEntZKsZwQHhzqcwG7MTqn
Specs that build a workspace at the repo root load the plugins in its .solargraph.yml, as the plugin CI jobs configure, and require_plugins then records them with CacheDir.add_plugin. That switched CacheDir.gem_dir to a cold plugin-keyed directory for the rest of the spec process. Save, clear and restore CacheDir.plugins and plugin_requires around every example, which also makes the per-spec CacheDir cleanup in shell_spec and config_spec redundant. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SEntZKsZwQHhzqcwG7MTqn
A before(:all) workspace load, such as the repo-root ApiMap that conversions_spec builds, runs outside the per-example around hook, so the plugins it records stayed in CacheDir for every later example. Save, clear and restore them around each context as well. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SEntZKsZwQHhzqcwG7MTqn
This reverts commit 86bc823.
This reverts commit 263da2c.
This was referenced Oct 21, 2026
Brings in castwide#1436 so CI builds rugged on Ubuntu 26.04 runners. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SEntZKsZwQHhzqcwG7MTqn
apiology
added a commit
to apiology/solargraph
that referenced
this pull request
Oct 22, 2026
Brings in castwide master's castwide#1436 rugged build fix via castwide#1407. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SEntZKsZwQHhzqcwG7MTqn
The five sg-ignores on Gem.loaded_specs.each_value.find in add_plugin and add_convention come from UniqueType#resolve_generics collapsing Enumerator parameters into one union for generic index 0, so the Enumerable#find block parameter becomes Elem | Return. castwide PR 1415 resolves every generic parameter and makes all five Unneeded. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
apiology
marked this pull request as draft
October 29, 2026 15:00
apiology
changed the title
Config#require_plugins and the private Shell helper have the side effect of requiring plugins and recording them in the gem cache key; the bang marks that. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LTpguHqALFufF4QdNagq1C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude: This PR was written by Claude Code on behalf of @apiology.
Builds on #1378.
Problem: In the language server, gem pins never get a plugin's contribution:
With #1378 gem pins are mapped from gem source and serialized, so whatever a plugin adds while mapping a gem is missing from the cache the server builds, while an in-process typecheck includes it. The cache key also ignores plugins, so adding or upgrading one keeps serving the old pins.
Solution:
solargraph cacheanduncacherequire the plugins configured for--directory(via a newWorkspace::Config#require_plugins, whichWorkspacenow delegates to), andCacheDir.gem_dirincludes each loaded plugin's name and gem version, so pins built with different plugin sets never share a directory.With no plugin loaded,
gem_diris unchanged. Core, stdlib and RBS collection pins come from RBS rather than parsed source, so their directories stay plugin-independent.The
@sg-ignoreinCacheDir.add_pluginrecords a typecheck defect:h.each_value.find { |v| v.even? }reportsUnresolved call to even? on Integer, Hash{String => Integer}.🤖 Generated with Claude Code