Repository navigation
feat(test-evm-tools): derive fork-block activation from the transition schedule - #3557
Open
spencer-tb wants to merge 1 commit into
Open
spencer-tb wants to merge 1 commit into
spencer-tb wants to merge 1 commit into
Conversation
2 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3557 +/- ##
================================================
Coverage 94.44% 94.44%
================================================
Files 624 624
Lines 36928 36928
Branches 3326 3326
================================================
Hits 34875 34875
Misses 1450 1450
Partials 603 603
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 tasks done
jochem-brouwer
left a comment
Member
There was a problem hiding this comment.
I did not thoroughly review this PR, just one comment. What is missing in this PR such that it is still draft? I could not get this from the description 😄 👍
spencer-tb
force-pushed
the
t8n/transition-schedule
branch
from
September 15, 2026 11:48
89fe081 to
62817f0
Compare
spencer-tb
marked this pull request as ready for review
September 15, 2026 11:50
…n schedule Co-authored-by: Jochem Brouwer <29359032+jochem-brouwer@users.noreply.github.com>
spencer-tb
force-pushed
the
t8n/transition-schedule
branch
from
September 15, 2026 11:52
62817f0 to
aed5b18
Compare
2 tasks done
This was referenced Oct 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge order: first. #3722 (EIP-8250) and #3535 (EIP-8253) build on it.
This is ported and edited from @jochem-brouwer's PR: #3535
Pass the tests fork transition schedule to the EELS t8n so it can identify the fork block and apply one time state changes. Previously, t8n received only the active fork for each block, losing the activation schedule.
The t8n tool now derives activation from that schedule, and
ethereum-spec-evm t8naccepts transition names such asBPO2ToAmsterdamAtTime15k. External tools continue to receive the active fork name for each block.Note, this will require the change on other client t8n tools as a follow up!
This provides the activation support needed by EIP-8253 (#3535).
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.