Repository navigation
feat(stars): add the central stars of the Ring, Owl, Helix and Southern Ring nebulae - #1352
Merged
Merged
Conversation
…t row as a limb record
# Conflicts: # src/objects/observable-universe/inventory.json
…fter merging main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ring, the Owl, the Helix and the Southern Ring each get their central star as an object inside the nebula: WD 1851+329, WD 1111+552, WD 2226-210 and the Southern Ring's faint white dwarf. A zoom in on each nebula goes on into its star, and the star's page keeps the nebula's walls around it. Each star is a sphere of the size that radiates its published luminosity at its published temperature: 93,000 to 112,000 K, two and a half to four times Earth's size.
The other three strips are in their READMEs.
Limits: no paper prints these radii; they follow from luminosity and temperature. Masses are unmeasured. Three stars are dimmed toward the edge by the nearest tabulated white-dwarf model (Claret et al. 2020, pure hydrogen, up to 100,000 K), not a measurement. The Southern Ring's star is a flat disc: nothing is published about its atmosphere; its values are those a model of the nebula needs, and its bright companion HD 87892 is not drawn. Tooling: the generator and the color reader now take temperatures up to 250,000 K. Headless Chrome only.
Prepared assets
inventory.json.Clean: generator and renderer tests, typecheck, lint and the repository checks.
PR rules.