Repository navigation
feat(core): category manager level for dispositions raised by a non-CM (#47) - #56
Merged
Merged
Conversation
srm_disposition_approval treated initiation as the category manager level, so a disposition raised by a buyer lead (who also holds srm_supplier_admin) went straight to the procurement director and skipped the CM level of the 03 §12 matrix. Like srm_contract_approval, the flow now looks up whether the initiator holds srm_category_manager; if not, a category manager approves first (recorded in the new read-only category_approver field), and the later levels' BR-11 checks also compare against that approver. The CM level is the first approval node on that path, so it can send the disposition back; the director then sits on a second node that can only approve or reject until objectstack#24817 ships. CM-initiated dispositions are unchanged. Docs: 03 §5 / §12, 02 disposition fields, GL-08 6.2.1 / 6.3.1 / 6.3.2 / ch. 7 / appendix A, ZC-02 and QP-01 appendix C notes. Closes #47 Claude-Session: https://claude.ai/code/session_01Ut39cZ4zdvuJmqenJzvnKh Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by 田騏 · project thread
Closes #47 (director ruling, v0.4 overview #34).
改了什么
srm_disposition_approval：照srm_contract_approval，开头查发起人是否持srm_category_manager岗位。director_review_after_category节点（maxRevisions: 0、无 revise 边）；平台修复后合并两个采购总监节点。categoryActor/directorActor/gmActor，初始化为空串），品类经理审批人也计入后面几级的撞人比对。srm_supplier_disposition：新增只读字段category_approver（品类经理审批人，加字段、不改已有名称），英文翻译同步。验证
test/disposition.test.ts新增 3 条（issue 里写的test/approval-matrix.test.ts不存在，用例放在处置单测试里）：category_approver/director_approver写入；category_approver为空。pnpm validate、pnpm lint（多出 2 条与其他审批节点同类的 info 建议）、pnpm typecheck、pnpm i18n:check、pnpm test（16 文件 158 条全过）、pnpm build全部通过；governance/scripts/build.py --check及--packs bulk,hazmat,soe通过。Generated by Claude Code