Repository navigation
build(deps-dev): bump tsdown from 0.22.14 to 0.23.1 in the development group - #58
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the development group with 1 update: [tsdown](https://github.com/rolldown/tsdown). Updates `tsdown` from 0.22.14 to 0.23.1 - [Release notes](https://github.com/rolldown/tsdown/releases) - [Commits](rolldown/tsdown@v0.22.14...v0.23.1) --- updated-dependencies: - dependency-name: tsdown dependency-version: 0.23.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: development ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. What this changesThis PR upgrades tsdown from 0.22.14 to 0.23.1 and refreshes its transitive build dependencies. Example: A contributor runs pnpm install --frozen-lockfile on Node 25.
Review scores
ProductKind: Maintenance · Worth it: No Regression provenancePossible regression — suspected (reviewed change). No predecessor PR is attributed. Merge readiness⛔ Blocked before merge - 3 items remain This PR breaks supported Node 25 development installs and reverses an explicit compatibility decision; repository policy does not permit automatic closure of this unimplemented update. Priority: P2 Before merge
Findings
Provenance
Agent review detailsHow this fits togethertsdown consumes the router's TypeScript entry point and produces the ESM bundle and declarations used by package validation and publication. flowchart LR
A[Contributor checkout] --> B[pnpm frozen install]
B --> C[Dependency engine checks]
C --> D[tsdown build]
D --> E[ESM and declarations]
E --> F[Package import validation]
Technical reviewBest possible solution: Retain the compatible tsdown 0.22.14 graph until an upgrade preserves the repository's declared Node support. Do we have a high-confidence way to reproduce the issue? The PR's locked engine ranges exclude Node 25, its installation job fails, and the corresponding main job passes; no local target code was executed. Is this the best way to solve the issue? This upgrade conflicts with the established compatibility contract; restoring the existing dependency graph is safer than narrowing supported Node versions or disabling engine enforcement. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 251c5f19a107. TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 14, 2026, 5:34 PM ET / 21:34 UTC. |
|
Closing this repeated incompatible upgrade at reviewed head This retains the established Node 25-compatible |
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Bumps the development group with 1 update: tsdown.
Updates
tsdownfrom 0.22.14 to 0.23.1Release notes
Sourced from tsdown's releases.
... (truncated)
Commits
6493257chore: release v0.23.1ba6acb9chore: upgrade deps6cbfec7chore(deps): update dependency unplugin-vue to v8 (#1090)eb40c95chore: declare package side effectsf9c95d0chore: align pnpm workspace settingse64bde4chore: configure pnpm via devEngines83f0c57fix(pkg): pack tarball insidenpm publish --dry-run(#1076)1745223fix(entry): honor custom root for object entry (#1072)9655dcbchore: upgrade deps30da631docs: correct default value ofminifyDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions