Skip to content

chore(container-runner): default stop grace to 10s - #5533

Open
abcxff wants to merge 1 commit into
stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpumfrom
stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup
Open

chore(container-runner): default stop grace to 10s#5533
abcxff wants to merge 1 commit into
stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpumfrom
stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup

Conversation

@abcxff

@abcxff abcxff commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@claude

claude Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@-

@abcxff
abcxff force-pushed the stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpum branch from f63600c to efaf873 Compare July 31, 2026 05:27
@abcxff
abcxff force-pushed the stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup branch from c142ce3 to 4a79659 Compare July 31, 2026 05:27
@abcxff
abcxff force-pushed the stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup branch from 4a79659 to 395bd37 Compare July 31, 2026 06:03
@abcxff
abcxff force-pushed the stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpum branch from efaf873 to 11b03c3 Compare July 31, 2026 06:03
@abcxff
abcxff force-pushed the stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpum branch from 11b03c3 to cb11619 Compare August 3, 2026 20:17
@abcxff
abcxff force-pushed the stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup branch from 395bd37 to 949ddff Compare August 3, 2026 20:17
@abcxff
abcxff force-pushed the stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup branch from 949ddff to ea1de83 Compare August 10, 2026 17:16
@abcxff
abcxff force-pushed the stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup branch 2 times, most recently from 688589a to 2dc2e02 Compare August 10, 2026 20:35
@abcxff
abcxff force-pushed the stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpum branch from 018143b to 2899a10 Compare August 10, 2026 20:35
@claude

claude Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review

Small, well-scoped change: lowers the default stop_grace_secs from 25s to 10s and generalizes doc comments away from Cloud-Run-specific wording to platform-agnostic language. No logic changes beyond the default value.

Verified consistency:

  • effective_stop_grace() (main.rs:161) takes min(stop_grace, signal_child_stop_grace()) on signal-initiated shutdown, where signal_child_stop_grace() is 40% of the 10s SIGTERM_BUDGET default (4s) — so the signal-shutdown path is unaffected by this change since 4 < 10 was already the binding constraint, and remains so at 4 < 10.
  • The engine-initiated stop path (actor.rs:151, child.stop(cfg.stop_grace)) now waits up to 10s instead of 25s before SIGKILL — this is the actual behavioral change from this PR.
  • sleep_grace_period (main.rs:314) is derived as stop_grace + 10s, so it drops from 35s to 20s as a side effect. Worth double-checking this is still comfortably above the real-world child shutdown time for the actors this runner hosts, since core aborts on_destroy mid-stop if this deadline is too short (per the comment above it).
  • No stale 25 references remain in README or comments.
  • The Cloud-Run-specific wording removed here still appears in container-runner/README.md and a few files under container-runner/examples/, which is fine since those weren't part of this PR's scope, but worth a follow-up sweep if the intent is to fully genericize the platform language.

No bugs, security, or test coverage concerns — this is a config-default/comment change with no new logic paths. No new tests are needed for a default-value tweak like this.

@abcxff
abcxff force-pushed the stack/fix-rivetkit-log-and-surface-actor-startup-failures-wyxwxpum branch from 2899a10 to e5d0c23 Compare August 10, 2026 22:09
@abcxff
abcxff force-pushed the stack/chore-container-runner-default-stop-grace-to-10s-xnpvnuup branch from 2dc2e02 to 85d3a2f Compare August 10, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant