fix(rivetkit): keep actor event loop alive through shutdown state serialization

[abcxff]

No description provided.

[abcxff]

Stack for rivet-dev/actors

• #5557 docs(container-runner): sync deploy docs with runner source
• #5556 fix(container-runner): read cgroup v1 memory usage under gvi …
• #5548 feat(container-runner): log version and git sha at actor sta …
• #5549 feat(container-runner): setup instance memory and cpu usage …
• #5546 fix(rivetkit): keep actor event loop alive through shutdown … 👈
• #5539 feat(container-runner): report actors as crashed on unexpect …
• #5536 feat(container-runner): log unexpected platform SIGTERM as a …
• #5530 fix(rivetkit-core): cancel driver alarm before sqlite teardo …
• #5531 feat(container-runner): keep instance warm instead of self-e …
• #5533 chore(container-runner): default stop grace to 10s
• #5528 fix(rivetkit): log and surface actor startup failures
• #5558 fix(sdks): drop rivet-util metrics dep from protocol crates …
• main

Get stack: forklift get 5546
Push local edits: forklift submit
Merge when ready: forklift merge 5546

_{change losmyvnt}

[claude]

Review

Root cause and fix check out. RunGracefulCleanup (start.rs:433) previously returned Ok(true) to end the run_actor event loop right after on_sleep/on_destroy. But rivetkit-core shutdown path (task.rs::run_shutdown -> save_final_state) always sends a follow-up ActorEvent::SerializeState after that cleanup hook, and only closes the event channel afterward (close_actor_event_channel, called after save_final_state). With the old early return, events/rx was already dropped by the time that SerializeState was enqueued, so send_actor_event hit the closed channel and failed with not_ready (task.rs:1071-1084), silently losing any state the sleep/destroy hook just wrote. Keeping the loop alive until core closes the channel matches the NAPI adapter existing behavior (napi_actor_events.rs drains its own JoinSet independently of cleanup dispatch, and start_grace already cancels the run task abort signal before RunGracefulCleanup is even sent, so extending the loop lifetime does not race the user run() handler), so this brings the Rust crate to parity as the comment claims.

The new regression test (run_actor_serializes_state_after_cleanup) is a good direct repro: it fails pre-fix (the request_serialize send would panic against a closed channel) and passes post-fix, verifying on_sleep-written state actually survives serialization. The systematic drop(tx) additions to the other request_sleep/request_destroy tests are correct and necessary now that the loop no longer self-terminates on RunGracefulCleanup; all 17 call sites got the matching drop, otherwise actor.await would hang forever waiting on the channel to close.

Minor: now-dead should_stop plumbing. handle_actor_event still returns Result, and the run_actor loop still does:

let should_stop = handle_actor_event(actor.clone(), ctx.clone(), event).await?;
if should_stop {
    break;
}

That was the only Ok(true) arm in the whole match (no other variant returns true), so should_stop is now unconditionally false and the loop only real exit is events.recv_raw().await returning None. Not a bug, but worth simplifying to Result<()> and dropping the should_stop/break scaffolding so a future reader does not think the loop can still be ended from inside handle_actor_event.

Other notes:

• No security or performance concerns: this does not introduce polling, just extends the existing async recv().await loop lifetime to match core actual event sequence. Since save_final_state bounds its SerializeState wait with a timeout (SERIALIZE_STATE_SHUTDOWN_SANITY_CAP or the configured sleep grace period) and always closes the channel afterward regardless of outcome, the loop cannot hang indefinitely even if a SerializeState reply is dropped or delayed.
• Scope is tightly contained to rivetkit-rust/packages/rivetkit/src/start.rs; no parity gap opened against NAPI (already behaved this way) or engine-runner/pegboard-envoy (unrelated).

Re-verified independently against the current diff on 2026-08-11; findings unchanged from the prior review.