improvement(tools): delete unreferenced tool response types and the dead generic resource data path - #8596
Conversation
…ead generic resource data path - delete 168 exported tool *Response types nothing references (mostly umbrella unions) and the 24 local types only they used - add-integration and add-tools templates declare one response type per tool and no umbrella union - drop the never-set genericResourceData chat field; the generic resource panel renders its empty state directly
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There was a problem hiding this comment.
All reported issues were addressed across 153 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
…nse-type guidance
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
*Responsetypes inapps/sim/tools/*/types.tsthat nothing references — almost all umbrella unions (type XResponse = | XGetResponse | ...) — and the 24 file-local types only those unions used. Types only, no runtime change; generated docs are unchanged (the generator readsexport constoutput properties, which are untouched).add-integrationandadd-toolstemplates now declare one response type per tool and say not to add an umbrella union, so new integrations stop recreating them.genericResourceDatawas never set (chore(lint): delete unused variables and parameters; enforce both rules repo-wide #8554 removed its setter), so every render path ended at an empty list. Drop the chat field and its pass-through props, and reduceGenericResourceContentto the empty state it always rendered;GenericResourceEntry/GenericResourceDatago with it. Thegenericresource type stays (it is in the generated wire contract).check:unused-exportsbaseline shrinks by 165 entries.Type of Change
Testing
bun run lint,bun run type-check,bun run check:audits(58, incl.docs:checkandcheck:unused-exports),docs-manifest:check, block-registry check, home vitest (376), rootbun run testChecklist
test-auditauthoring gate)🤖 Generated with Claude Code