Skip to content

improvement(tools): delete unreferenced tool response types and the dead generic resource data path - #8596

Merged
waleedlatif1 merged 2 commits into
stagingfrom
improvement/dead-tool-response-types
Oct 3, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
improvement/dead-tool-response-types

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Delete the 168 exported *Response types in apps/sim/tools/*/types.ts that nothing references — almost all umbrella unions (type XResponse = | XGetResponse | ...) — and the 24 file-local types only those unions used. Types only, no runtime change; generated docs are unchanged (the generator reads export const output properties, which are untouched).
  • add-integration and add-tools templates now declare one response type per tool and say not to add an umbrella union, so new integrations stop recreating them.
  • genericResourceData was never set (chore(lint): delete unused variables and parameters; enforce both rules repo-wide #8554 removed its setter), so every render path ended at an empty list. Drop the chat field and its pass-through props, and reduce GenericResourceContent to the empty state it always rendered; GenericResourceEntry/GenericResourceData go with it. The generic resource type stays (it is in the generated wire contract).
  • check:unused-exports baseline shrinks by 165 entries.

Type of Change

  • Improvement

Testing

  • bun run lint, bun run type-check, bun run check:audits (58, incl. docs:check and check:unused-exports), docs-manifest:check, block-registry check, home vitest (376), root bun run test

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

…ead generic resource data path

- delete 168 exported tool *Response types nothing references (mostly umbrella unions) and the 24 local types only they used
- add-integration and add-tools templates declare one response type per tool and no umbrella union
- drop the never-set genericResourceData chat field; the generic resource panel renders its empty state directly
@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 3, 2026 8:21am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Removes unused tool response type unions and generic resource UI.

The PR appears safe to merge; no new actionable issue or outstanding previous finding was identified.

Summary

This PR removes unused tool response types and the unused generic-resource data path, while updating integration templates to discourage umbrella response unions.

  • Tool-specific response types and runtime tool definitions remain in place.
  • Generic resources retain their empty-state panel.

Reviews (2) · Last reviewed commit: "chore(skills): name InternalToolConfig b..."

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 153 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread .agents/skills/add-tools/SKILL.md Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 153 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 81a4256 into staging Oct 3, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/dead-tool-response-types branch October 3, 2026 08:32

This branch was successfully deployed

1 active deployment
Preview — 83dd21cf Deployed Oct 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant