fix(store): enforce conditions at delete and multipart commit - #59
Draft
tobi wants to merge 1 commit into
Draft
Conversation
Extract the storage corrections identified in PR #8. S3 conditional delete drops from two requests to one; compose removes its destination HEAD. GCS invalid update tokens fail locally. Include SDK transport regressions and bounded StoreConditions controls/witnesses.
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3 previously checked a version with HEAD before an unconditional delete, and multipart composition checked the destination before staging. A rival write in either window could be removed or replaced. Apply native conditions at DELETE or multipart completion, and abort incomplete or oversized multipart input. GCS rejects malformed/nonpositive update generations before upload.
Extracts the storage corrections from #8. Healthy conditional delete is one request instead of two; a refused compatible-store delete may probe to distinguish a missing object. Compose removes the destination preflight and conditions the final commit.
Validation: 60 storage unit tests and the real RustFS storage contract pass locally. StoreConditions adds a fixed arm, three precise mutations and four reachability witnesses, with Rust twins documented in docs/spec/README.md. Real GCS validation requires an external test bucket.
Stack layer 1/8; base: main. Review the diff against this base. Combined tree at 4475bb4 passes local
just ci(38 e2e tests, 19 serial simulations and standalone smoke) and the real two-instance S3 push/maintenance/clone/fsck rig. All six ignored stress/benchmark tests and all 184 full TLC checks pass locally (15 new checks across two models). The follow-up at 37bc4cc changes only two shell test assertions to Bash builtins; it passes with a minimal PATH. All eight stack heads are green in hosted CI (26 jobs). This layer’s successful run.Review order: 01-conditional-storage → 02-s3-credentials → 03-lfs-batches → 04-lfs-metrics → 05-auth-boundaries → 06-dev-setup → 07-azure → 08-azure-events.