feat(lfs): record handler outcomes and honest byte metrics - #62
Draft
tobi wants to merge 1 commit into
Draft
Conversation
Adapt PR #51 with explicit offered-download and validated-upload counters. Exclude HEAD/304/error/offloaded responses; count HTTP errors even when returned as Ok(Response). A recorder regression covers range and dropped-response semantics.
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record LFS handler duration and HTTP outcomes for batch, GET, PUT and verify. Distinguish bytes offered in a GET response from validated upload bytes; neither counter claims transport delivery. HEAD, 304, errors and edge offload do not count as offered response bytes.
Reworks #51 around measurable semantics. A local recorder regression covers response outcomes and offered-byte exclusions. docs/LFS.md describes measurement boundaries, including upload validation preceding storage completion.
Stack layer 4/8; base: backlog/03-lfs-batches. Review the diff against this base. Combined tree at 4475bb4 passes local
just ci(38 e2e tests, 19 serial simulations and standalone smoke) and the real two-instance S3 push/maintenance/clone/fsck rig. All six ignored stress/benchmark tests and all 184 full TLC checks pass locally (15 new checks across two models). The follow-up at 37bc4cc changes only two shell test assertions to Bash builtins; it passes with a minimal PATH. All eight stack heads are green in hosted CI (26 jobs). This layer’s successful run.Review order: 01-conditional-storage → 02-s3-credentials → 03-lfs-batches → 04-lfs-metrics → 05-auth-boundaries → 06-dev-setup → 07-azure → 08-azure-events.