fix(auth): constrain LFS writes and popup identity messages - #63
Draft
tobi wants to merge 1 commit into
Draft
Conversation
Extract the remaining authorization fixes from PR #8. Upload batches require write access; unknown operations reject. The popup targets an allowlisted opener or its own origin, safely encodes identity JSON, and the SDK checks the opened window and origin. API integration tests passed.
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require write authorization for upload batch actions and reject unknown batch operations. Send popup identity messages only to the same origin or an explicitly allowed caller origin, encode principal data safely in script context, and have the SDK verify both sender origin and popup identity.
Extracts the auth corrections from #8. Local API/LFS regressions cover read-only upload rejection, unknown operations, disallowed origins and script-closing principal text. The SDK passes lint, typecheck and production build.
Stack layer 5/8; base: backlog/04-lfs-metrics. Review the diff against this base. Combined tree at 4475bb4 passes local
just ci(38 e2e tests, 19 serial simulations and standalone smoke) and the real two-instance S3 push/maintenance/clone/fsck rig. All six ignored stress/benchmark tests and all 184 full TLC checks pass locally (15 new checks across two models). The follow-up at 37bc4cc changes only two shell test assertions to Bash builtins; it passes with a minimal PATH. All eight stack heads are green in hosted CI (26 jobs). This layer’s successful run.Review order: 01-conditional-storage → 02-s3-credentials → 03-lfs-batches → 04-lfs-metrics → 05-auth-boundaries → 06-dev-setup → 07-azure → 08-azure-events.