[Birfy]

Fixes #1414

Owner: Dev
Reviewer: Reviewer

What changed

Approach: both (1) and (2). They share failCutoffRun / archiveCutoffRun so in-flight nodes are failed when a run is cut off (aligned with #1424 / PR #1431 intent).

• dispose() — Before releasing ephemeral Bots (workflow: dispose() drops the ephemeral Bot records before the release finishes #1387 order unchanged), every live run still in lane.active with status === 'running' is failed, archived off active, then ephemeral ids are released and stripped.
• reap() — Still reaps runs that have an ephemeral map and are running (workflow: reap() skips running runs, and it only runs once at plugin load #1388). Additionally treats live && status === 'running' && !ephemeral as abandoned (prod zombie shape after an older unload) and heals them without calling release.

Verification at the tip

Tip SHA: d37f6a4a017064b73d57df73989e226807133811

Ran:

• node --test plugins/workflow/test/*.test.js → 74 pass
• node --test plugins/workflow/test/dispose.test.js plugins/workflow/test/ephemeral.test.js → 14 pass

Not run: root npm run verify (workflow-only change; no core/ edits).

Docs-not-needed: docs/subsystems/workflow.md updated in this PR.

Checkpoint

{
  "pr": 1465,
  "claim": "Dev",
  "issue": 1414,
  "summary": "Plugin unload no longer leaves workflow runs persisted as running after ephemeral Bot ids are cleared. dispose() fails in-flight nodes and archives live runs before release. reap() also ends live running runs that already lost their ephemeral map, freeing lane capacity after restart.",
  "files": [
    "plugins/workflow/src/service.js",
    "plugins/workflow/test/dispose.test.js",
    "plugins/workflow/test/ephemeral.test.js",
    "docs/subsystems/workflow.md",
    "changelog.d/1414-workflow-dispose-zombie.fixed.md"
  ],
  "checks": {
    "ran": "node --test plugins/workflow/test/*.test.js",
    "result": "green",
    "at": "d37f6a4a017064b73d57df73989e226807133811"
  },
  "next": "none — ready for review"
}

Written-by: Dev

  

[Birfy]

Verdict: PASS at d37f6a4
Written-by: Reviewer
Attestation: d37f6a4 role=Reviewer

Ran:

• git fetch origin && git rev-parse HEAD → pass (d37f6a4)
• git diff origin/main...HEAD --stat → pass (5 files, workflow plugin only)
• PATH=/workspace/tools/node24/bin:$PATH TZ=UTC npm run verify → pass
• node --test plugins/workflow/test/dispose.test.js plugins/workflow/test/ephemeral.test.js → pass (14/14)
• PR tests vs origin/main service.js (revert source only) → fail 5/14 as expected (workflow: dispose() drops the ephemeral Bot records before the release finishes #1387, workflow: a run whose ephemeral map is gone leaves its hidden run Bots unreapable #1414, workflow: reap() skips running runs, and it only runs once at plugin load #1388)
• GH_REPO=ThinkFlowLab/FlyBot node .github/scripts/risk-gate.mjs --pr 1465 → pass (T2)

Not run:

• core smoke bench — no core/host delivery change
• Desktop manual exercise — workflow plugin unload/reload only covered by unit tests

Findings

No actionable code defects for #1414 at this tip.

• dispose() fails in-flight nodes, archives live running runs off active, then releases ephemerals (workflow: dispose() drops the ephemeral Bot records before the release finishes #1387 order preserved).
• reap() still handles abandoned runs with an ephemeral map (workflow: reap() skips running runs, and it only runs once at plugin load #1388) and heals running zombies without ephemeral (workflow: a run whose ephemeral map is gone leaves its hidden run Bots unreapable #1414); finished runs unchanged.
• docs/subsystems/workflow.md updated; changelog fragment present.
• Security fence / display-name: out of scope (no delivery or remote-string paths).

Implementer ↔ reviewer

Agree with PR claims on verification scope; independent npm run verify at tip matches.

This report is not merge authority; T2 still needs green CI at tip after PASS is posted.