Skip to content

AddToIgs improvements 1: mini/micro-optimisations - #235

Merged
fingolfin merged 1 commit into
gap-packages:masterfrom
stertooy:igs-improv-1
Oct 16, 2026
Merged

fingolfin merged 1 commit into
gap-packages:masterfrom
stertooy:igs-improv-1

Conversation

@stertooy

Copy link
Copy Markdown
Collaborator

Extracted from #174. That PR does a lot of (sometimes independent) changes, my hope is that it's easier to get that reviewed by splitting it in smaller chunks.

Original PR disclaimer:
Assisted-by: Claude Code (Opus 5.5, Fable 5.1)

 - Only reduce exponents if a relative order is 0
 - Sort and clean duplicates from todo
 - Don't wrap IGSValFun in lists
 - Less unnecessary calculations in TailLimit

Assisted-by: Claude Code (Opus 5.5, Fable 5.1)
@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.83%. Comparing base (109f23a) to head (f336e71).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   67.81%   67.83%   +0.01%     
==========================================
  Files          88       88              
  Lines       12916    12924       +8     
==========================================
+ Hits         8759     8767       +8     
  Misses       4157     4157              
Files with missing lines Coverage Δ
gap/basic/pcppara.gi 92.38% <100.00%> (+0.15%) ⬆️
gap/basic/pcppcps.gi 82.86% <100.00%> (+0.12%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stertooy stertooy changed the title Small optimisations for AddToIgs code AddToIgs improvements 1: mini/micro-optimisations Oct 12, 2026
@fingolfin
fingolfin merged commit c7aa72d into gap-packages:master Oct 16, 2026
5 checks passed
@stertooy
stertooy deleted the igs-improv-1 branch October 21, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants