Skip to content

fix(ci): regenerate fingerprinted CSS before QA Hugo build (#2912) - #2917

Merged
jung-thomas merged 1 commit into
DEVfrom
worktree-fix-qa-icon-css
Oct 25, 2026
Merged

jung-thomas merged 1 commit into
DEVfrom
worktree-fix-qa-icon-css

Conversation

@jung-thomas

Copy link
Copy Markdown
Contributor

Problem

QA full rebuilds have been failing for several hours (#2912) — 5+ consecutive failures. Every run dies at the Build QA Hugo site step:

head.html:27:64 at <minify>: wrong type for value;
expected resources.ResourceTransformer; got resource.Resource

Root cause

Commit ac6b7e39f (#2896 follow-up, "stop committing generated CSS so deploy & rebuild agree on fingerprint") made fundamental-styles-icon.css (build:icon-subset) and sap-fundamental.css (build:css) git-ignored build outputs, and added both regeneration steps to the prod rebuild-content.yml before its Hugo build.

The QA workflow (rebuild-content-qa.yml) drives /tmp/hugo directly (not npm run build:all) and was never given those steps. On a clean CI checkout the icon CSS is absent, so head.html:27 (resources.Get "css/fundamental-styles-icon.css" | minify) resolves to a non-transformable global resource and the build throws.

Fix

Add a Build fingerprinted CSS (sap-fundamental + icon subset) step before the QA Hugo build, mirroring rebuild-content.yml lines 826–829. QA and prod now regenerate byte-identical CSS and agree on the fingerprint.

Verification

  • npm run build:icon-subset regenerates hugo/assets/css/fundamental-styles-icon.css (the missing file) — confirmed locally after deleting it.
  • npm run build:css regenerates sap-fundamental.css — confirmed.
  • YAML parses; new step is correctly ordered before "Build QA Hugo site".

Targets DEV per branching model.

The QA rebuild workflow builds Hugo directly via /tmp/hugo rather than
`npm run build:all`, but was never given the build:icon-subset + build:css
steps that commit ac6b7e3 (#2896 follow-up) added to the prod
rebuild-content.yml when it .gitignored those generated CSS outputs.

On a clean CI checkout fundamental-styles-icon.css is therefore absent, so
head.html:27 (resources.Get "css/fundamental-styles-icon.css" | minify)
fails with "wrong type for value; expected resources.ResourceTransformer;
got resource.Resource" and every QA full rebuild dies at the Hugo step.

Add a "Build fingerprinted CSS" step before the QA Hugo build, mirroring
rebuild-content.yml, so QA and prod regenerate byte-identical CSS and agree
on the fingerprint.
@jung-thomas
jung-thomas merged commit ab2acda into DEV Oct 25, 2026
3 of 4 checks passed
@jung-thomas
jung-thomas deleted the worktree-fix-qa-icon-css branch October 25, 2026 11:53
jung-thomas added a commit that referenced this pull request Oct 25, 2026
docs: record QA/PROD rebuild-workflow parity rule (follow-up to #2917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant